7cc5c4f330d47060/geode
1
0
Fork 0
mirror of https://github.com/geode-sdk/geode.git synced 2025-02-17 00:30:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

redo logic for mod target gd version

Browse source 
it was busted idk what i was on when i wrote it, it wouldnt be able to
load anything newer than the geode gd version
This commit is contained in:
matcool 2024-01-18 10:25:47 -03:00
parent 753fd4e152
commit 562e73d610
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
loader/src/loader/ModMetadataImpl.cpp
View file

@ -8,6 +8,7 @@
#include <utility>
#include "ModMetadataImpl.hpp"
#include "LoaderImpl.hpp"
using namespace geode::prelude;
@ -190,8 +191,24 @@ Result<ModMetadata> ModMetadata::Impl::create(ModJson const& json) {
if (ver.empty()) {
return Err("[mod.json] could not find GD version for current platform");
}
if (ver != "*" && ver != GEODE_STR(GEODE_GD_VERSION)) {
return Err(fmt::format("[mod.json] doesn't support this GD version ({} != {})", ver, GEODE_STR(GEODE_GD_VERSION)));
if (ver != "*") {
// probably a bad idea but oh well
float modTargetVer;
try {
// assume gd version is always a valid float
modTargetVer = std::stof(ver);
} catch (...) {
return Err("[mod.json] has invalid target GD version");
}
if (LoaderImpl::get()->isForwardCompatMode()) {
// this means current gd version is > GEODE_GD_VERSION
if (modTargetVer <= GEODE_GD_VERSION) {
return Err(fmt::format("[mod.json] doesn't support this GD version ({} < current version)", ver));
}
} else if (modTargetVer != GEODE_GD_VERSION) {
// we are not in forward compat mode, so GEODE_GD_VERSION is the current gd version
return Err(fmt::format("[mod.json] doesn't support this GD version ({} != {})", ver, GEODE_STR(GEODE_GD_VERSION)));
}
}
} else {
return Err("[mod.json] is missing target GD version");