define NOMINMAX

cmake/Platform.cmake

@@ -58,7 +58,7 @@ elseif (GEODE_TARGET_PLATFORM STREQUAL "Win32")
 		${GEODE_LOADER_PATH}/include/Geode/cocos/cocos2dx/platform/third_party/win32/OGLES
 	)
 
-	target_compile_definitions(${PROJECT_NAME} INTERFACE -DCC_TARGET_OS_WIN32)
+	target_compile_definitions(${PROJECT_NAME} INTERFACE -DCC_TARGET_OS_WIN32 NOMINMAX)
 
 	target_link_libraries(${PROJECT_NAME} INTERFACE 
 		${GEODE_LOADER_PATH}/include/link/libcocos2d.lib

loader/include/Geode/utils/general.hpp

@@ -10,8 +10,6 @@
 #include <vector>
 #include <ghc/filesystem.hpp>
 
-#undef snprintf
-
 // for some reason std::filesystem::path doesn't have std::hash defined in C++17 
 // and ghc seems to have inherited this limitation
 template<>

loader/include/Geode/utils/ranges.hpp

@@ -7,9 +7,6 @@
 #include <optional>
 #include <iterator>
 
-#undef min
-#undef max
-
 #ifndef __cpp_lib_concepts
 namespace std {
     // <concepts> isn't working for me lmao

loader/src/ui/internal/info/ModInfoPopup.cpp

@@ -23,10 +23,6 @@
 #include <Geode/utils/web.hpp>
 #include <loader/LoaderImpl.hpp>
 
-// TODO: die
-#undef min
-#undef max
-
 static constexpr int const TAG_CONFIRM_UNINSTALL = 5;
 static constexpr int const TAG_DELETE_SAVEDATA = 6;
 static const CCSize LAYER_SIZE = {440.f, 290.f};

loader/src/ui/nodes/Scrollbar.cpp

@@ -1,10 +1,6 @@
 #include <Geode/ui/Scrollbar.hpp>
 #include <Geode/utils/cocos.hpp>
 
-// TODO: die
-#undef min
-#undef max
-
 USE_GEODE_NAMESPACE();
 
 bool Scrollbar::ccTouchBegan(CCTouch* touch, CCEvent* event) {

loader/src/ui/nodes/TextRenderer.cpp

@@ -2,8 +2,6 @@
 #include <Geode/utils/casts.hpp>
 #include <Geode/utils/cocos.hpp>
 #include <Geode/utils/string.hpp>
-#undef max
-#undef min
 
 USE_GEODE_NAMESPACE();
 using namespace std::string_literals;