7cc5c4f330d47060/geode
1
0
Fork 0
mirror of https://github.com/geode-sdk/geode.git synced 2025-02-17 00:30:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ok so float was not precise enough

Browse source
This commit is contained in:
matcool 2024-01-18 11:47:07 -03:00
parent a0515fad26
commit 25dc6eea5b
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
loader/src/loader/ModMetadataImpl.cpp
View file

@ -193,10 +193,10 @@ Result<ModMetadata> ModMetadata::Impl::create(ModJson const& json) {
}
if (ver != "*") {
// probably a bad idea but oh well
float modTargetVer;
double modTargetVer;
try {
// assume gd version is always a valid float
modTargetVer = std::stof(ver);
// assume gd version is always a valid double
modTargetVer = std::stod(ver);
} catch (...) {
return Err("[mod.json] has invalid target GD version");
}
@ -205,7 +205,7 @@ Result<ModMetadata> ModMetadata::Impl::create(ModJson const& json) {
if (modTargetVer <= GEODE_GD_VERSION) {
return Err(fmt::format("[mod.json] doesn't support this GD version ({} < current version)", ver));
}
} else if (modTargetVer != GEODE_GD_VERSION) {
} else if (ver != GEODE_STR(GEODE_GD_VERSION)) {
// we are not in forward compat mode, so GEODE_GD_VERSION is the current gd version
return Err(fmt::format("[mod.json] doesn't support this GD version ({} != {})", ver, GEODE_STR(GEODE_GD_VERSION)));
}