7cc5c4f330d47060/geode
1
0
Fork 0
mirror of https://github.com/geode-sdk/geode.git synced 2024-11-21 10:38:27 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

use vector insert instead of copy

Browse source
This commit is contained in:
Chloe 2024-09-07 06:44:52 -07:00
parent fc44452fd4
commit 1040c4ffea
No known key found for this signature in database
GPG key ID: D2D404DD810FE0E3
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
loader/src/server/Server.cpp
View file

@ -830,9 +830,8 @@ void server::queueBatches(
if (result->ok()) {
auto serverValues = result->unwrap();
// we should probably do deduplication here as well
accum->reserve(accum->size() + serverValues.size());
std::copy(serverValues.begin(), serverValues.end(), std::back_inserter(*accum));
accum->insert(accum->end(), serverValues.begin(), serverValues.end());
if (batches->size() > 1) {
batches->pop_back();
@ -868,7 +867,7 @@ ServerRequest<std::vector<ServerModUpdate>> server::checkAllUpdates(bool useCach
auto modBatches = std::make_shared<std::vector<std::vector<std::string>>>();
auto modCount = modIDs.size();
std::size_t maxMods = 200u; // this quite literally affects 0.03% of users
std::size_t maxMods = 200u; // this affects 0.03% of users
if (modCount <= maxMods) {
// no tricks needed
@ -888,7 +887,7 @@ ServerRequest<std::vector<ServerModUpdate>> server::checkAllUpdates(bool useCach
return ServerRequest<std::vector<ServerModUpdate>>::runWithCallback(
[modBatches](auto finish, auto progress, auto hasBeenCancelled) {
auto accum = std::make_shared<std::vector<ServerModUpdate>>();
queueBatches(finish, modBatches, std::move(accum));
queueBatches(finish, modBatches, accum);
},
"Mod Update Check"
);