diff --git a/ConfirmAccount/business/AccountRequestSubmission.php b/ConfirmAccount/business/AccountRequestSubmission.php index 376c7f1..89c41c5 100644 --- a/ConfirmAccount/business/AccountRequestSubmission.php +++ b/ConfirmAccount/business/AccountRequestSubmission.php @@ -110,9 +110,13 @@ class AccountRequestSubmission { if ($_POST['pwd1'] != $_POST['pwd2']) { return array('pwds_no_match', 'The passwords did not match.'); } + + if (strlen($_POST['pwd1']) <= 4) { + return array('pwd_too_short', 'The password is too short'); + } if (!$success) { - return array('no_comment', 'It does not appear you commented the verification code on the specified project. Please try again.'); + return array('no_comment', $this->msg('requestaccount-nocomment-error')); } $u = User::newFromName( $this->userName, 'creatable' ); diff --git a/ConfirmAccount/frontend/language/RequestAccountPage.i18n.php b/ConfirmAccount/frontend/language/RequestAccountPage.i18n.php index 648bb06..6832ecb 100644 --- a/ConfirmAccount/frontend/language/RequestAccountPage.i18n.php +++ b/ConfirmAccount/frontend/language/RequestAccountPage.i18n.php @@ -75,7 +75,8 @@ You cannot make any more requests.", 'requestaccount-code-troubleshoot' => '\'\'\'Note:\'\'\' If you are having problems with user verification not working, please see our [[Scratch_Wiki:Become a contributor/Verification code troubleshooting|troubleshooting page]]', 'requestaccount-set-pwd' => 'Set password', 'requestaccount-project-info' => 'Please go to the [$1 user verification project] and comment the following code:
\'\'\'$2\'\'\'', - 'requestaccount-project-link' => 'http://scratch.mit.edu/projects/10135908/' + 'requestaccount-project-link' => 'http://scratch.mit.edu/projects/10135908/', + 'requestaccount-nocomment-error' => 'It does not appear you commented the verification code on the specified project. Please try again.', ); /** Message documentation (Message documentation) diff --git a/ConfirmAccount/frontend/specialpages/actions/ConfirmAccount_body.php b/ConfirmAccount/frontend/specialpages/actions/ConfirmAccount_body.php index 0a9441f..2274ba4 100644 --- a/ConfirmAccount/frontend/specialpages/actions/ConfirmAccount_body.php +++ b/ConfirmAccount/frontend/specialpages/actions/ConfirmAccount_body.php @@ -295,13 +295,13 @@ class ConfirmAccountsPage extends SpecialPage { $form .= '' . $this->msg( 'confirmaccount-leg-user' )->escaped() . ''; $form .= ''; $form .= ""; - $form .= "\n"; + $form .= '' . "\n"; $econf = ''; - if ( $accountReq->getEmailAuthTimestamp() ) { + /*if ( $accountReq->getEmailAuthTimestamp() ) { $econf = ' ' . $this->msg( 'confirmaccount-econf' )->escaped() . ''; } $form .= ""; - $form .= "\n"; + $form .= "\n";*/ if ( count( $wgAccountRequestTypes ) > 1 ) { $options = array(); $form .= "
" . Xml::label( $this->msg( 'username' )->text(), 'wpNewName' ) . "" . Xml::input( 'wpNewName', 30, $this->reqUsername, array( 'id' => 'wpNewName' ) ) . "
' . Xml::input( 'wpNewName', 30, $this->reqUsername, array( 'id' => 'wpNewName', 'type' => 'hidden' ) ) . ' ' . htmlspecialchars($this->reqUsername) . '
" . $this->msg( 'confirmaccount-email' )->escaped() . "" . htmlspecialchars( $accountReq->getEmail() ) . $econf . "
" . htmlspecialchars( $accountReq->getEmail() ) . $econf . "
" . $this->msg( 'confirmaccount-reqtype' )->escaped() . ""; @@ -661,8 +661,8 @@ class ConfirmAccountsPage extends SpecialPage { } } - # Every 30th view, prune old deleted items - if ( 0 == mt_rand( 0, 29 ) ) { + # Every 10th view, prune old deleted items + if ( 0 == mt_rand( 0, 10 ) ) { ConfirmAccount::runAutoMaintenance(); } } diff --git a/ConfirmAccount/frontend/specialpages/actions/RequestAccount_body.php b/ConfirmAccount/frontend/specialpages/actions/RequestAccount_body.php index 1e50b97..baa0fa9 100644 --- a/ConfirmAccount/frontend/specialpages/actions/RequestAccount_body.php +++ b/ConfirmAccount/frontend/specialpages/actions/RequestAccount_body.php @@ -230,7 +230,7 @@ class RequestAccountPage extends SpecialPage {
' . "\n"; $form .= ''; - + # FIXME: do this better... global $wgConfirmAccountCaptchas, $wgCaptchaClass, $wgCaptchaTriggers; if ( $wgConfirmAccountCaptchas && isset( $wgCaptchaClass )