Commit graph

124 commits

Author SHA1 Message Date
Chris Garrity
8914c15493 revert ios scroll fix
The ‘fix’ for the ios scrolling bug prevented scrolling of the library. Things need to be refactored.
2019-10-31 13:04:37 -04:00
Chris Garrity
abc78daca6 Revert paint change for android
This didn’t fix the paint issue, just changed which kind of devices see the problem. Reverted the change to work for cheaper, regular density tablets.
2019-10-31 07:48:58 -04:00
Chris Garrity
5a5e5bdf12 remove duplicate ontouchmove 2019-10-25 13:49:31 -04:00
Chris Garrity
c4ea194df7 Fix scrolling while dragging
This is the fix from Paula for #217

based on the firebase-analytics branch, so only merge after that PR (or cherry pick this commit)
2019-10-25 12:46:11 -04:00
Chris Garrity
c8f655447a Address comments 2019-10-25 12:27:32 -04:00
Chris Garrity
2c4520e9e1 improve paint_editor event
There was only one paint editor event and it only distig,nuished between character or background. This change distinguishes between editing a background from the library vs user-created. For characters it distinguishes between new and edit, and between library assets or user-created.
2019-10-23 08:58:53 -04:00
Chris Garrity
b6a1569438 Fix analytics issues
* Pass value `0` for email analytics event (everything was being reported as airdrop even when it was email)
* Use `id` for assets (corresponds to the asset file name, e.g. Star.svg) instead of `fieldname` which is localized.
2019-10-22 15:55:55 -04:00
Chris Garrity
b965440709 Switch to firebase analytics
* Remove ScratchJrApplication class - it was only being used to initialize the old Google Analytics.
* Change AppUsage (home, school, other, noanswer) from being a prefix on `label` to being a Firebase user property.
* Set the user property when loading the index page - it shouldn’t change for the rest of the session.
2019-10-21 10:48:03 -04:00
chrisgarrity
cd2503768e Hide parents button after succesful parental gate 2019-04-22 10:40:48 -04:00
chrisgarrity
32f7f5174d
Merge pull request #210 from chrisgarrity/feature/revised-share-flow
Move the parental gate before the share buttons
2019-04-16 11:35:54 -04:00
chrisgarrity
49d8b5a3df Move the parental gate before the share buttons
Change the share flow to have a ‘For Parents’ button that brings up the Parental Gate. Share buttons only become visible after a successful challenge.
2019-04-06 16:44:37 -04:00
Donald
b8109b8a8f expose scratchjr to global 2018-11-02 20:23:32 +08:00
chrisgarrity
2da0c818bf
Merge pull request #192 from Murkantilism/develop
Replaced hardcoded value of 136 with a variable.
2018-10-29 09:05:17 -04:00
Deniz Ozkaynak
ae0d60cb43
Replaced hardcoded value of 136 with a variable. 2018-10-13 20:36:29 -04:00
Deniz Ozkaynak
844765bde6
Created a variable to replace a hardcoded value
In ../src/editor/ui/UI.js there's a random hardcoded value of 136 that helps determine the scale of fullscreen mode. Not sure what this number represents but it should be a variable.
2018-10-13 20:35:10 -04:00
Donald
29ebbeece6 Code format & sort npm script params 2018-09-11 14:27:15 +08:00
Donald
d60ea5e7cb Upgrade webpack to 4.18.0
Add 'watch' and 'dev' npm scripts
2018-09-11 14:13:38 +08:00
chrisgarrity
a4737a4399 Don’t adjust paintEditor point on Android
Fixes the issue where the editor doesn’t draw where the finger is touching on Android.
2018-05-02 15:01:45 -04:00
chrisgarrity
9336953985 Add languages
Added:
- German
- Japanese
- Portuguese
- Swedish
- Chinese (China)

Needed to modify Localization utilities to handle China locale in additional to language.
2017-09-16 14:33:28 -04:00
chrisgarrity
0f2c31bfc9 Add documentation for AppUsage
Also make ternary operators easier to read.
2017-08-23 11:53:13 -04:00
chrisgarrity
1862c41394 Revise cookie 2017-08-14 15:58:57 -04:00
chrisgarrity
b6a36dbf32 Handle official catface and logo
Hide all the usage elements, and re-show the logo/catface if coming from the usage page.
2017-08-11 09:13:52 -04:00
chrisgarrity
952ce54b52 Don’t reload index
Instead of reloading the page, just load Start and have Start hide the usage parts.
2017-08-10 17:03:30 -04:00
chrisgarrity
852df3edbb Add splash page for usage tracking
* Adds a usage cookie
* Only asks for usage on first launch
* will need checking with the official version to make sure the right elements are showing/hiding.
2017-08-10 10:00:22 -04:00
chrisgarrity
16e4b7ce27 Limit size of sounds
We know that projects with lots of (large) sounds tend to crash ScratchJr. Hopefully reducing the size of the sounds will help to reduce the number of crashes.
2017-07-17 11:25:59 -04:00
chrisgarrity
f752ff5760 Fix formatting and restart bug
In the current system you can’t have the same sound playing more than once at the same time - this is how it was implemented on Android, so we used the same restriction on iOS.

However in the previous version if you interrupted the sound to play it again, it continued from where it was instead of starting over. So it didn’t appear to do anything. Added resetting the current time to 0.0 on play to restart sounds.
2017-03-14 14:31:18 -04:00
chrisgarrity
e9d0d0d7be Change iOS to use native sound.
This is after the coding session with Paula - mostly just clean up of obsolete code and leftover debugging output.
2017-03-08 11:16:31 -05:00
chrisgarrity
6a6d92e06b [WIP] new audio engine
Post coding session with Paula
2017-02-21 17:17:35 -05:00
chrisgarrity
e035b0f86e Sanitize filename
Allow non-latin characters, but remove anything that could be problematic
2016-09-19 15:17:13 -04:00
chrisgarrity
9923c34e76 Add new languages to ScratchJr
Needed slight adjustment to css for settings
added new language codes to settings.json and Localizations.js
2016-09-06 17:33:17 -04:00
chrisgarrity
6e46696d2c Localize sample project name 2016-06-22 11:58:48 -04:00
chrisgarrity
3d6e015a6b Add settings to index page topbar
Add the settings button to the topbar - used in the PBS Kids version.
2016-05-26 14:00:21 -04:00
Tim Mickel
70ddc00913 Merge pull request #56 from tmickel/bugfix/storystarter-autosave
Prevent new projects via autosave in story-starter mode
2016-04-11 14:37:51 -04:00
Tim Mickel
7fd14cc6d4 Add missing line-break in UI.js 2016-04-11 14:31:04 -04:00
Tim Mickel
5dd0bc964e Prevent new projects via autosave in story-starter mode 2016-04-11 14:13:45 -04:00
Tim Mickel
ae52b67863 Disable autosave when onHold, Project.saving, or info box open 2016-04-11 14:01:26 -04:00
Tim Mickel
c49870dd6b Add link for gear icon to settings page 2016-03-24 15:57:36 -04:00
Tim Mickel
b9a232d90b Add gear icon to top right of splash page 2016-03-24 15:46:15 -04:00
Tim Mickel
693698c514 SVG2Canvas.processXMLnode to not getElementById
This addresses #29 in iOS, which was causing photos in thumbnails to not crop. A note about what was going on is included in the code.
2016-03-24 14:05:45 -04:00
Tim Mickel
6676b37a80 Remove for-of loop which requires Symbol polyfill 2016-02-08 12:43:12 -05:00
Tim Mickel
db3724072f Only polyfill window.Intl when it doesn't exist
The Chrome Webview already had an existing window.Intl. This was causing an assignment error.
2016-02-08 12:33:33 -05:00
Tim Mickel
9f45c2f7a8 Add config for disabling the lobby settings page
In some editions we may not have completed translations. For these, the settings page can be hidden.
2016-02-03 15:51:16 -05:00
Tim Mickel
09773e3186 Add analytics event for changing the language 2016-02-03 15:34:41 -05:00
Tim Mickel
f715c5054c Fix IO.refreshLobby for modules 2016-02-03 12:02:57 -05:00
Tim Mickel
de99fabacc Fixing broken iOS import in ScratchAudio 2016-02-03 11:32:46 -05:00
Tim Mickel
6cde452728 Add getter for currentLocale to Localization.js #465 2016-02-03 11:19:28 -05:00
Tim Mickel
ad7e80adfd Adding about page localizations for PBS KIDS 2016-02-02 18:31:27 -05:00
Tim Mickel
1a0801b74d Reconciliation of PBS KIDS edition splash page 2016-02-02 18:19:06 -05:00
Tim Mickel
1da87914cc Refactor app.js entry-point to have different JS files for each page 2016-02-02 17:43:22 -05:00
Tim Mickel
9814b2a7ce Provide top-level window.ScratchAudio to iframes 2016-02-02 17:31:16 -05:00