From b6a1569438a7bb269526e92b09f4e30a5ee93b8a Mon Sep 17 00:00:00 2001
From: Chris Garrity <chrisg@media.mit.edu>
Date: Tue, 22 Oct 2019 15:55:55 -0400
Subject: [PATCH] Fix analytics issues

* Pass value `0` for email analytics event (everything was being reported as airdrop even when it was email)
* Use `id` for assets (corresponds to the asset file name, e.g. Star.svg) instead of `fieldname` which is localized.
---
 src/editor/ui/Library.js | 10 +++++++++-
 src/editor/ui/UI.js      |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/editor/ui/Library.js b/src/editor/ui/Library.js
index 7288ff2..96ce963 100644
--- a/src/editor/ui/Library.js
+++ b/src/editor/ui/Library.js
@@ -521,7 +521,7 @@ export default class Library {
 
         // Prevent reporting user asset names
         if (clickThumb) {
-            var analyticsName = clickThumb.fieldname;
+            var analyticsName = clickThumb.id;
             if (!(selectedOne in MediaLib.keys)) {
                 analyticsName = 'user_asset';
             }
@@ -536,6 +536,14 @@ export default class Library {
         if (selectedOne) {
             ScratchJr.stage.currentPage.setBackground(selectedOne, ScratchJr.stage.currentPage.updateBkg);
         }
+
+        if (clickThumb) {
+            var analyticsName = clickThumb.id;
+            if (!(selectedOne in MediaLib.keys)) {
+                analyticsName = 'user_background';
+            }
+            iOS.analyticsEvent('editor', 'choose_background', analyticsName);
+        }
         Library.close(e);
     }
 
diff --git a/src/editor/ui/UI.js b/src/editor/ui/UI.js
index 767c4c1..9cc3474 100644
--- a/src/editor/ui/UI.js
+++ b/src/editor/ui/UI.js
@@ -134,7 +134,7 @@ export default class UI {
             shareEmail.id = 'infoboxShareButtonEmail';
             shareEmail.textContent = Localization.localize('SHARING_BY_EMAIL');
             shareEmail.ontouchstart = function (e) {
-                UI.infoDoShare(e, nameField, shareLoadingGif, 1);
+                UI.infoDoShare(e, nameField, shareLoadingGif, 0);
             };
 
             if (isAndroid) {