Commit graph

69 commits

Author SHA1 Message Date
Matthew Taylor
cd3fb9245a Only apply offset to teachers
thanks @chrisgarrity!
2017-04-14 14:18:32 -04:00
Matthew Taylor
cb7ce8c71d update language for age validation
thanks @TheGrits!
2017-04-13 07:41:47 -04:00
Matthew Taylor
2c472b607a Only allows birthdays > 13 yrs old for teacher reg
Helps fix https://github.com/LLK/scratchr2/issues/4470 from the UX side of things
2017-04-12 17:41:43 -04:00
Matthew Taylor
63c6bf59f2 Merge pull request #1149 from mewtaylor/issue/r2-4092
For R2-4092: Add checkbox to opt-in to teacher emails
2017-03-15 10:08:35 -04:00
Matthew Taylor
f59774bd0d Don’t localize an empty string 2017-02-23 09:52:33 -05:00
Matthew Taylor
ca0985571e Revert "Merge pull request #1149 from mewtaylor/issue/r2-4092"
This reverts commit 8e82398255, reversing
changes made to e1a0e9fece.
2017-01-31 11:38:50 -05:00
Matthew Taylor
8e82398255 Merge pull request #1149 from mewtaylor/issue/r2-4092
For R2-4092: Add checkbox to opt-in to teacher emails
2017-01-19 18:37:11 -05:00
chrisgarrity
e1a0e9fece Fix GH 1102: Don’t allow duplicate strings in a single l10n file (#1150)
* Don’t allow duplicate strings in a single l10n file

Added check_duplicate_strings to test for duplicates in a single file.
removed duplicates - tried to keep the more generic ‘key’

* revised test case for safer file reads
2017-01-19 18:23:56 -05:00
Matthew Taylor
313f267cfe Add checkbox to opt-in to teacher emails 2017-01-17 15:57:15 -05:00
Ray Schamp
afe63af707 Provide intl to TeacherRegistration 2016-12-19 17:02:03 -05:00
Ray Schamp
c901675b41 Allow empty response, again
Missed in #1128, this fixes the rest of the handler to not expect a body from the request. Fixes #1124 again.
2016-12-19 15:41:32 -05:00
Ray Schamp
3b396019ab Allow empty responses
Fixes #1124 by not assuming there is any body associated with the response.  That we don't send one is news to me, but we should cover this possibility in any case.
2016-12-19 13:43:33 -05:00
Ray Schamp
64ceb2ae56 Provide fallback error messages
In case the response does not supply `msg` or `errors`, provide a default. If `registrationError(s)` is empty, we do not show the error card, which causes "silent" failures.
2016-12-13 12:12:23 -05:00
Matthew Taylor
9ae4e5a963 Move validationRequired into general
thanks @rschamp!
2016-12-07 17:24:48 -05:00
Ray Schamp
e218cc5169 Move "select country" to general strings
It's reused in the other registration views so doesn't belong in teacherregistration/l10n.json

Fixes #783
2016-07-28 12:26:56 -04:00
Matthew Taylor
cf4a057278 Fix “afterschool” typo
Also make default country selectable in the user demographic step, and fix the spacing with `Create a Username`
2016-07-27 23:33:45 -04:00
Ray Schamp
7455807591 Provide RegistrationError content as children
This allows us to do more inline formatting, so we don't have any of that outside of `render`.

Thanks @mewtaylor
2016-07-22 09:38:37 -04:00
Matthew Taylor
859877c1ff refresh session on successful registration
This is needed to ensure that the approval step displays the correct “Wait for Approval” message. Fixes #698
2016-07-21 12:57:49 -04:00
Ray Schamp
47ebef1b6f Scope message strings more reusably 2016-07-19 16:51:10 -04:00
Ray Schamp
67ecb60f48 Make registration styles reusable 2016-07-19 16:49:12 -04:00
Ray Schamp
5b6a1fe8b9 Fix whitespace 2016-07-19 09:24:07 -04:00
Technoboy10
8c260032fa card margin auto 2016-07-18 10:39:13 -04:00
Matthew Taylor
7741cb2c7e Merge pull request #685 from St19Galla/patch-1
Fix gh-684 - Changing error message
2016-07-12 19:04:16 -04:00
Matthew Taylor
075f1481a2 Add custom validation for organization and phone
It appears that the `required` field is not applied in the way we'd like it to be for the custom checkbox group and custom phone input fields, so do a `required` check on form submission. Additionally, this adds in a few style fixes. Fixes #695, #694, #693, #691
2016-07-07 16:56:51 -04:00
St19_Galla
ea6cd2ab2c final fix 2016-07-07 14:18:16 -04:00
St19_Galla
16a985212c alphanumeric only text fix 2016-07-06 21:20:46 -04:00
Ray Schamp
554e21cd15 Fix localization of address validation message
Fixes #608
2016-06-30 15:54:32 -04:00
Matthew Taylor
9fb6170569 style error-step like last-step
Since they're both mostly info cards. Fixes #627.
2016-06-29 14:08:16 -04:00
Matthew Taylor
0c1abada3a Small tweaks
1. left-align form elements even in mobile
2. Bolden input labels, except for checkboxes and radio elements

/cc @carljbowman
2016-06-23 15:44:14 -04:00
Matthew Taylor
6aeee284bc style waiting room
also "deep purple" :)
2016-06-23 15:25:22 -04:00
Matthew Taylor
10f154ca10 accidentally took this out 2016-06-23 15:10:41 -04:00
Matthew Taylor
1a08e7ae49 Finalize styling for registration flow
/cc @carljbowman

One issue we ran into is that our `frameless` configuration is in `em` rather than `rem`, making it difficult to have an aboslute grid applied uniformly at all hierarchies. For now, we're using straight `rem` calculations instead of `$cols{1,8}` in the styling until we can refactor `frameless` to use `em`.
2016-06-23 14:06:36 -04:00
Matthew Taylor
1910d38bc6 Merge branch 'feature/teacher-registration-flow' of https://github.com/rschamp/scratch-www into feature/teacher-registration-flow
* 'feature/teacher-registration-flow' of https://github.com/rschamp/scratch-www:
  Add teacher waiting room view
  Only pass necessary props to steps

# Conflicts:
#	src/components/registration/steps.jsx
#	src/views/teacherregistration/teacherregistration.jsx
2016-06-23 07:35:06 -04:00
Matthew Taylor
8fb16bf397 Add formatting for teacher reg flow 2016-06-23 07:27:43 -04:00
Ray Schamp
93ed60cd0d Add teacher waiting room view 2016-06-22 13:35:38 -04:00
Ray Schamp
de8ac6c56a Only pass necessary props to steps
Rather than lazily including all form progress to every step, just give each step what it needs.
2016-06-21 18:45:41 -04:00
Ray Schamp
bf76e88ca2 Add serverside email validation 2016-06-17 13:01:53 -04:00
Ray Schamp
11b9876930 Clean up 2016-06-17 12:22:29 -04:00
Ray Schamp
078463ac25 Move registration step to main component
Add a placeholder error step
2016-06-17 12:22:11 -04:00
Ray Schamp
8646bd84b3 Submit the rest of the fields when registering 2016-06-17 11:01:34 -04:00
Ray Schamp
532a1cce57 This help text is redundant now 2016-06-17 11:01:10 -04:00
Ray Schamp
ad5da0f543 Fix organization "other" field enablement 2016-06-17 11:00:48 -04:00
Ray Schamp
d7ca0166ab Get the form creating regular accounts 2016-06-16 17:25:14 -04:00
Ray Schamp
e062096445 Add progress indicators 2016-06-16 10:54:36 -04:00
Ray Schamp
1fba322d01 Style pass 2016-06-15 15:08:56 -04:00
Ray Schamp
8da8ab4100 Add serverside username validation
With this we get cleanspeak for free
2016-06-14 17:29:31 -04:00
Ray Schamp
8dac67f292 L10n pass 2016-06-14 17:29:31 -04:00
Ray Schamp
f74a078afb Add help text when a field is not required
Most of our fields are required, so it makes more sense to display help when they are optional than to asterisk every required field
2016-06-14 17:29:31 -04:00
Ray Schamp
667ff08a36 L10n WIP 2016-06-14 17:29:31 -04:00
Ray Schamp
ce007d64f8 Change password confirmation to "show password" 2016-06-14 17:29:30 -04:00