Ben Wheeler
a59d533a1c
merged changes in report modal and add to studio handling
2018-07-16 13:39:29 -04:00
Ben Wheeler
bc7b31e924
finished draft of intermediary refactor of addtostudio modal redux code, container-presentation code simplified
2018-07-13 09:50:17 -04:00
Ben Wheeler
6a32edb2fe
addtostudiomodal: incomplete progress on 1. container-presentation refactor, 2. redux handling of add and leave studio requests
2018-07-11 15:08:01 -04:00
Ben Wheeler
9cac70ab18
small steps towards addtostudio modal's container-presentation refactor
2018-07-07 14:09:43 -04:00
Ben Wheeler
d9543314cc
small comment
2018-07-05 13:34:41 -04:00
Ben Wheeler
af25e44fc6
refactoring add to studio modal into container and presentation; added getCuratedStudios functionality to preview
2018-07-04 18:01:11 -04:00
Ben Wheeler
6989fd4ecf
Added SVGs for add to studio modal
2018-06-27 11:38:32 -04:00
Ben Wheeler
ab0ec0f10e
simplified addtostudio modal code
2018-06-22 09:19:44 -04:00
Ben Wheeler
6e4cd63e95
spinner logic works, at least with mocked situation and no request or response from server
2018-06-20 23:12:54 -04:00
Ben Wheeler
0a6ec304d3
starting to change addtostudios modal to make changes on the fly
2018-06-20 20:25:46 -04:00
Ben Wheeler
c25bfab7bb
improved addtostudio modal variable names
2018-06-20 08:38:16 -04:00
Ben Wheeler
0f819f6a49
addtostudio formatting much closer to design spec
2018-06-20 00:19:52 -04:00
Ben Wheeler
e44b21a712
fixed elusive setState bug in addToStudio modal, by calling setState only when content is confirmed to have changed
2018-06-19 22:43:50 -04:00
Ben Wheeler
b44c8ab60b
debugger statements back in, some tiny fixes
2018-06-19 15:43:07 -04:00
Ben Wheeler
e89325889b
got gradient overlay working on addtostudio modal
2018-06-19 13:46:17 -04:00
Ben Wheeler
db4e64e4c7
cleaned up debug code, formatting of addtostudio buttons
2018-06-19 12:59:27 -04:00
Ben Wheeler
1b874b748c
further debugging addtostudio modal
2018-06-19 11:26:02 -04:00
Ben Wheeler
61dda43b8f
further debugging addtostudio modal
2018-06-19 11:07:25 -04:00
Ben Wheeler
b18ddeedaf
better handling of addtostudio modal scrollbar; attempting to debug its setstate calls
2018-06-19 10:47:17 -04:00
Ben Wheeler
16190f1147
got addtostudio modal state changes to work, though not updating to server yet
2018-06-19 10:13:40 -04:00
Ben Wheeler
bc0a5f64f7
add to studio modal: notes on next steps
2018-06-19 00:14:32 -04:00
Ben Wheeler
e05079a28c
mocked my permissioned studios
2018-06-19 00:00:37 -04:00
Ben Wheeler
4c657a1e80
showing actual studio membership, though not unadded studios yet
2018-06-18 23:36:20 -04:00
Ben Wheeler
847e204efc
add to studio modal scrollbar formatting works
2018-06-18 19:47:43 -04:00
Ray Schamp
9e02798f7b
Lint
2018-06-18 17:19:12 -04:00
Ben Wheeler
f8df3c0146
added royal blue color, button styles, small jsx fixes to Add to Studio modal
2018-06-18 15:17:19 -04:00
Ben Wheeler
9d9226f4a4
got rid of bug keeping page from displaying
2018-06-16 19:28:28 -04:00
Ben Wheeler
f0fbc0a57f
add to studio modal appears from project page, looks horrendous
2018-06-16 19:13:50 -04:00
Ray Schamp
4ce05622bc
Move report options from state
...
These never change so don't belong there.
2018-06-14 09:22:00 -04:00
chrisgarrity
74c76fb1cf
Refactor report-modal
...
* addresses comments for https://github.com/LLK/scratch-www/pull/1900
* renames report fields to match scratchr2 expectations
* restyle modal to allow display of validation messages
* removed cruft
2018-06-01 15:25:28 -04:00
chrisgarrity
db3120091d
Fix lint and don’t duplicate the ‘other’ string
2018-05-31 15:02:45 -04:00
chrisgarrity
71dfe690be
First pass at correcting project input styles
...
* Add placeholders to description input text-areas
* fix styling to show box shadow highlight on focus
* adjust height for non-remix project
* fix lint errors
2018-05-31 15:02:45 -04:00
chrisgarrity
08cf4f4f3d
Refactor report modal
...
* move all the report modal presentation into the component
* add strings to general l10n file because we don’t handle l10n files in components
* Add current project id and username to the data before submitting
2018-05-31 15:02:44 -04:00
chrisgarrity
34042c9e8e
Report first pass
...
Report button opens a modal with the report project form. All the content is currently in `preview/presentation` because components cannot have their own l10n files.
2018-05-31 15:02:44 -04:00
Ray Schamp
590f505a61
Revert "Merge pull request #1788 from LLK/revert-1775-hotfix/es6-upgrade"
...
This reverts commit 1b1b396e92a144bab0e6
2018-01-30 11:53:12 -05:00
Ray Schamp
46511e1253
Revert "[Develop] Upgrade to ES6"
2018-01-30 09:54:45 -05:00
chrisgarrity
4633086bf3
Remove blue outline around modals
2018-01-29 08:56:03 -05:00
Ray Schamp
2a64d61fed
Fix registration modal close behavior
2018-01-25 15:01:42 -05:00
Matthew Taylor
6d1f2fbccd
initial es6 commit
2018-01-19 14:06:26 -05:00
chrisgarrity
e1a0e9fece
Fix GH 1102: Don’t allow duplicate strings in a single l10n file ( #1150 )
...
* Don’t allow duplicate strings in a single l10n file
Added check_duplicate_strings to test for duplicates in a single file.
removed duplicates - tried to keep the more generic ‘key’
* revised test case for safer file reads
2017-01-19 18:23:56 -05:00
morant
012321721c
Remove isRequired from description and onGuideClick, and fix naming on l10n strings.
2016-12-20 12:58:16 -05:00
chrisgarrity
58656aea17
Additional content changes
...
- new FlyCards.pdf (fixes shortcut url on title page)
- changes ‘download’ to ‘open’ for PDFs
2016-11-21 11:06:12 -05:00
Matthew Taylor
9ca54e83ce
Merge pull request #1008 from mewtaylor/issue/gh-980
...
Implement GH-980: add new TTT modal component
2016-11-18 17:41:26 -05:00
Ray Schamp
c966f8a0ba
Fix modal layout
...
The styles in the upgraded react-modal broke our centering.
The auto-focusing on the modal made an annoying blue border around it in Chrome.
2016-05-26 16:00:28 -04:00
Ray Schamp
19f469db48
Upgrade and quiet sass-linter
...
These warnings were annoying me because the noise makes it easy to miss real issues.
The `no-mergeable-selectors` rule is one that we do want to have, but right now it asks that you merge selectors in different `@media` blocks. When the next release happens we should put that back.
https://github.com/sasstools/sass-lint/issues/307
Similarly, we want `force-element-nesting` but there is a problem with that because there's no easy way to have a nested selector in a list of selectors.
https://github.com/sasstools/sass-lint/issues/575
Finally, until they implement per-line overrides, we have to silence `class-name-format` because we don't have control over the ReactModal class names. It's a useful rule to keep class names consistent though. Per-line ignores should be coming soon: https://github.com/sasstools/sass-lint/issues/70
2016-03-23 18:34:54 -04:00
Matthew Taylor
112cad14e3
Added some more documentation
2016-01-14 10:25:03 -05:00
Ray Schamp
14fd4c5860
Fix GH-168: Rehabilitate the Modal props.style
...
This makes it more sane, and consistent with the way the react-modal `Modal` works. The old way made multiple modals on the page have the same `style` prop.
2015-10-24 17:15:03 -04:00
Ray Schamp
65734a9577
Adapt to upgraded react-modal style handling
2015-10-20 19:28:28 -04:00
Andrew Sliwinski
0868a70f00
Remove unused responsive styles from modal.scss
2015-10-20 13:13:08 -04:00
Ray Schamp
da9174c520
Make app more transparent to Selenium
2015-10-09 14:16:37 -06:00
