Commit graph

2168 commits

Author SHA1 Message Date
chrisgarrity
32aa3e66d4
Merge pull request #2153 from LiFaytheGoblin/2133/move-media-queries-to-frameless
Move media queries used in responsive project page to frameless
2018-10-09 10:56:11 -04:00
chrisgarrity
47f71c2758 Fix confict resolution error
I missed one of the changes when resolving conflicts.
2018-10-09 10:24:02 -04:00
Paul Kaplan
c622d52396 Pass the topLevelCommentId to make sure nested comment deleting works 2018-10-09 10:16:35 -04:00
Paul Kaplan
e29caceb6b
Merge pull request #2150 from paulkaplan/new-comment
Add comments to projects and replies to comments
2018-10-09 10:02:17 -04:00
Benjamin Wheeler
341428ce50
storage.js can use PROJECT_HOST env setting (#2146) 2018-10-09 09:59:04 -04:00
Paul Kaplan
58ab51a629 Add messages for other rejected comment reasons 2018-10-09 09:36:42 -04:00
Paul Kaplan
9b122470f5 Fix formatting from review comments 2018-10-09 09:36:42 -04:00
Paul Kaplan
24fe4fef65 Use topLevelCommentId to simplify adding and deleting comments
This fixes the nested comment deletion problem: https://github.com/LLK/scratch-www/issues/2151
2018-10-09 09:36:41 -04:00
Paul Kaplan
744c90501e Add comments to projects and replies to comments 2018-10-09 09:36:41 -04:00
chrisgarrity
7af2c8a80a
Merge branch 'develop' into 2133/move-media-queries-to-frameless 2018-10-09 09:12:58 -04:00
Ray Schamp
ab08aa4281
Merge pull request #2152 from LiFaytheGoblin/2133/subactions-share-date-as-prop
[new project page] share date is passed as a prop to subactions component
2018-10-08 21:35:38 +01:00
Ray Schamp
3f5f224a76
Merge pull request #2107 from LiFaytheGoblin/responsive-project-page/container-width
Make container smaller for mobile to allow for space left and right
2018-10-08 18:13:40 +01:00
Linda
14741e1cb8 if the report or add to studio modals are open, don't switch to fulls… (#2145)
* if the report or add to studio modals are open, don't switch to fullscreen on orientationchange landscape

* fix linting errors
2018-10-05 18:00:52 -04:00
Linda
d358c45482 media queries used in responsive project page have been moved to frameless.css 2018-10-05 10:25:56 -04:00
Linda
8db5216f17 share date is passed as a prop to subactions 2018-10-05 09:15:09 -04:00
Linda
bf3977821a fixed linting errors 2018-10-04 10:51:26 -04:00
Linda
ad1531aff3 fixes to spacing around page content and a few other fixes 2018-10-04 10:41:10 -04:00
Linda
502ead072f Merge branch 'develop' into responsive-project-page/container-width 2018-10-04 10:25:48 -04:00
Linda
79afc55f26
Merge pull request #2108 from LiFaytheGoblin/responsive-project-page/modals
Make modals responsive
2018-10-04 10:23:35 -04:00
Linda
8476cd3152 solution from before was not working if combined with current develop branch 2018-10-04 09:47:28 -04:00
Paul Kaplan
24e1c92b74
Merge pull request #2141 from paulkaplan/comment-delete
Add comment deleting for project owners on preview
2018-10-03 16:26:50 -04:00
Linda
27d7a3bf59
Merge pull request #2135 from LiFaytheGoblin/responsive-project-page/header
Make header of new project page look good on mobile
2018-10-03 15:41:03 -04:00
Linda
1aa30fb10b
Merge pull request #2136 from LiFaytheGoblin/responsive-project-page/see-inside-remix-buttons
New project page: See inside and remix buttons disappear on mobile
2018-10-03 15:40:47 -04:00
Paul Kaplan
a3f1ccc132 Fix sass-lint 2018-10-03 14:00:56 -04:00
Paul Kaplan
24b456873b Add comment deleting for project owners 2018-10-03 13:31:54 -04:00
Linda
fc57218066 fix linting errors 2018-10-03 11:12:56 -04:00
Linda
a3df002b49 resolve mergin issues 2018-10-03 11:03:18 -04:00
Linda
437334b872 resolve merging conflicts 2018-10-03 10:54:53 -04:00
Linda
193a4ac70a
Merge branch 'develop' into responsive-project-page/see-inside-remix-buttons 2018-10-03 10:45:10 -04:00
Linda
38b8e2e97e on mobile, remix credit is still a flex row 2018-10-03 10:32:12 -04:00
Linda
f11d338d65 text gets vertically centered 2018-10-03 10:29:45 -04:00
Linda
57e147e110 remove commented out css 2018-10-03 10:09:44 -04:00
Linda
8009978c06 fixed linting errors 2018-10-03 10:09:44 -04:00
Linda
6f5b5c3278 extract css for new components and make some fixes to validation in report modal 2018-10-03 10:09:44 -04:00
Linda
5832969912 fixed linting errors 2018-10-03 10:09:44 -04:00
Linda
0895719f36 subactions getting own component 2018-10-03 10:09:44 -04:00
Linda
d85ca5d755 subactions getting their own component 2018-10-03 10:05:21 -04:00
Linda
b4a4ded822 share date positioning on small screens 2018-10-03 09:59:15 -04:00
Linda
8b10f3cba4 made project stats and action buttons responsive 2018-10-03 09:58:01 -04:00
Linda
2408568dda Merge branch 'develop' into responsive-project-page/see-inside-remix-buttons 2018-10-02 17:03:18 -04:00
Linda
a525e09cf6 Merge branch 'develop' into responsive-project-page/header 2018-10-02 16:59:01 -04:00
Linda
d0257ae43d
Merge pull request #2105 from LiFaytheGoblin/responsive-project-page/landscape-player
If in landscape format on mobile, switch to fullscreen mode
2018-10-02 16:38:57 -04:00
Linda
f55dd02665 never mind screen.orientation 2018-10-02 15:42:29 -04:00
Linda
06bb9c60c4 fixed problem where sometimes there would be two scrollbars 2018-10-02 15:33:15 -04:00
Linda
b03bd51f79 fixed linting error 2018-10-02 13:57:41 -04:00
Linda
7c8fdbfcc3 fixed height of studio buttons scrolling container to fill all modal 2018-10-02 13:49:56 -04:00
Linda
a0b190aa87
Merge pull request #2118 from LiFaytheGoblin/responsive-project-page/notes-section
Made project notes look better on mobile
2018-10-01 19:30:36 -04:00
Linda
3432d95cdb
Merge pull request #2117 from LiFaytheGoblin/responsive-project-page/comments
Made comments look better on mobile
2018-10-01 19:30:25 -04:00
Linda
ef1b7d8f9f checking for landscape browser proof 2018-10-01 16:58:05 -04:00
Linda
d5641daae6 improve solution for spacing in container and used desktop variable instead of hardcoded value 2018-10-01 13:56:11 -04:00
Linda
f1738ca384 improved the code stylewise 2018-10-01 09:52:50 -04:00
Linda
3010db684d
Merge pull request #2116 from LiFaytheGoblin/responsive-project-page/thumbnailcolumns
Thumbnailcolumns appear at bottom on mobile
2018-09-28 13:57:24 -04:00
Linda
ec067778f2
Merge pull request #2099 from LiFaytheGoblin/2067/project-page/comments-fade-out-safari
Made comments fade out look nice in Safari too
2018-09-28 13:57:11 -04:00
Ray Schamp
5278e77e0c
Merge pull request #2098 from chen-robert/gh1930-teacher-register-year
Fix gh-1930: Teacher registration dates
2018-09-28 10:58:26 -04:00
Linda
50c7eb9bfd added todo 2018-09-27 10:31:32 -04:00
Ray Schamp
1ad9a95a3d Add placeholder share handler
Having the `onShare` prop defined to a function enables the button in the GUI
2018-09-26 21:42:44 -04:00
Linda
e014906125 linting fixes 2018-09-26 17:26:19 -04:00
Linda
3d67488b29
Merge pull request #2106 from LiFaytheGoblin/responsive-project-page/extension-buttons
Extension buttons are responsive
2018-09-26 17:19:38 -04:00
Linda
fa049d79fc
Merge pull request #2112 from LiFaytheGoblin/2104/remove-mod-pos-from-jobs
Removed moderator position from jobs page
2018-09-26 17:19:14 -04:00
Linda
32ab0202bc made project notes look better on mobile 2018-09-26 17:16:17 -04:00
Linda
b5a49e6cf2 linting fixes 2018-09-26 16:45:42 -04:00
Linda
c18a073e17 some fixes 2018-09-26 16:39:37 -04:00
Linda
532e201f53 made comments roughly responsive 2018-09-26 16:36:48 -04:00
Linda
cc57d0f206 removed stuff that doesn't belong into this pr 2018-09-26 15:01:25 -04:00
Linda
4f3d77f42a some fixes and adapted remix and studio thumbnails 2018-09-26 14:55:17 -04:00
Linda
a4e7ee35e4 adapted show and remix button to mobile 2018-09-26 14:54:33 -04:00
Linda
4299afaec5 fixes to warning and thumbnailcolumns for mobile WIP 2018-09-26 14:35:36 -04:00
Robert Chen
a94b9d6c84 Fix gh-1934: Search bar special chars (#2075)
* Fixed Issue 1934

The text was encoded once already by the search bar. That means we need to decode it twice in order to decode special characters.

* Rewrote search query parsing
2018-09-26 14:16:56 -04:00
Linda
7465c2e85a removed sth that isn't part of the title issue 2018-09-26 12:02:00 -04:00
Linda
6445c7471e some fixes and adapted remix and studio thumbnails 2018-09-26 11:52:32 -04:00
Linda
6b2ddcd217 adapted title area for mobile 2018-09-26 11:48:29 -04:00
Linda
89aaaab4d3 removed moderator position from jobs page 2018-09-26 10:24:53 -04:00
Linda
35194803b4 fixed linting errors 2018-09-25 16:06:46 -04:00
Linda
a5d2ee18ef fixed validation message for modals 2018-09-25 15:58:10 -04:00
Linda
d061e2afe9 improve responsiveness for project page modals and also clean up the modals a bit 2018-09-25 15:40:27 -04:00
Linda
55cdeea04d wip refactored and responsive project page modals 2018-09-25 15:37:52 -04:00
Linda
f1c6f6c223 fixed linting errors 2018-09-25 15:31:31 -04:00
Linda
4983fb3f8c solution for container size for screen size between tablet and 942 according to design 2018-09-25 15:21:26 -04:00
Linda
51bb905381 extensions appear on correct place depending on media query 2018-09-25 15:04:31 -04:00
Linda
d066e73b91 extensions buttons made responsive 2018-09-25 14:49:37 -04:00
Linda
56f1b80f24 if in landscape format on mobile, switch to fullscreen mode 2018-09-25 14:36:34 -04:00
Benjamin Wheeler
eb9abd23a0
fixed errors in splash page that appear in develop (#2077) 2018-09-25 00:52:23 -04:00
Benjamin Wheeler
935eb0b15f
move login/registration functions and view state to session reducer, pass to gui (#2078)
* move login/registration functions and view state to session reducer, pass to gui

* navigation reducer handles login; gui passed renderLogin function

* put back in join class to make smoke tests keep working
2018-09-24 11:04:30 -04:00
Linda
a160180245 added transparent for ui primary for cross browser support to colors css 2018-09-21 13:26:49 -04:00
Linda
c047612d68
Merge pull request #2083 from LiFaytheGoblin/2082/project-page/project-notes-alignment
Fix notfications box, player box, buttons and icons alignments
2018-09-21 10:03:58 -04:00
Linda
0d894e3208 convention of writing hsl is with percentages 2018-09-21 09:57:49 -04:00
Linda
8bc158118e fixed color gradiant display in Safari 2018-09-21 09:53:58 -04:00
Robert Chen
86551baa94 Fixed Issue 1930 2018-09-20 22:15:24 -07:00
Linda
f721c9591a Ok, css that doesn't work in all browsers is not an option... 2018-09-20 10:33:00 -04:00
Linda
c9b2306827 removed some stuff that is not needed anymore 2018-09-19 16:17:14 -04:00
Linda
a9872a14ff fixed problem that occured with remix credits 2018-09-19 15:03:20 -04:00
Linda
d0d7bba70e
Merge pull request #2079 from LiFaytheGoblin/2065/title-too-long-warning
Implemented design for title-too-long-warning
2018-09-18 13:20:13 -04:00
Linda
42f0ed16e5
Merge pull request #2073 from LiFaytheGoblin/2005/animate-add-to-studio-buttons
Animate add-to-studio-buttons on preview project page
2018-09-14 12:28:44 -04:00
Linda
0a50c1fb34 align notes box and player box on same y pos and align buttons and icons below notifications and player at same y pos 2018-09-13 14:58:00 -04:00
Linda
497aae2a3c convention fixes 2018-09-13 11:04:14 -04:00
Linda
35558bfdba fixed linking problems 2018-09-13 10:49:59 -04:00
Linda
8a8f3b6da1 implemented title too long warning design 2018-09-13 10:39:19 -04:00
Linda
a60bd65887 positioning of alert field incomplete 2018-09-12 17:28:27 -04:00
Linda
c54b7413bc replaced old spinner with new svg to work everywhere where spinner is used 2018-09-12 14:54:15 -04:00
Linda
1cee3c68fc removed some leftovers 2018-09-11 17:18:09 -04:00
Linda
a8ebdb7d32
Merge pull request #2046 from LiFaytheGoblin/2045/project-page/studio-thumbnails
Fix appearance of studio thumbnails on preview project page
2018-09-11 10:10:21 -04:00
Linda
0898054e41
Merge pull request #2043 from LiFaytheGoblin/1986/project-page/fit-title-length
Keep title on preview project page from overflowing or otherwise messing up the layout
2018-09-11 10:08:38 -04:00
Linda
7313f26530 fixed linting errors 2018-09-07 16:45:17 -04:00
Linda
b582b31491 added comments and improved spin animation a little 2018-09-07 16:19:49 -04:00
Linda
ab4f8a09ce the animation now works 2018-09-07 16:11:37 -04:00
Benjamin Wheeler
3271c54744
Merge pull request #2052 from benjiwheeler/rename_title
pass project title to GUI, and disable submit when editing title
2018-09-07 16:03:16 -04:00
Linda
ed604a21d4 add studio buttons animation on preview page, need fixing 2018-09-07 09:26:11 -04:00
Ben Wheeler
2a19bb283f no need to pass title to embedded gui 2018-09-06 16:54:12 -04:00
Ben Wheeler
2f5604d23d localized Title too long error string 2018-09-05 18:38:19 -04:00
Ben Wheeler
478a30efcb pass project title to GUI, and disable submit when editing title 2018-09-05 18:38:19 -04:00
Ben Wheeler
4bf0964bf2 moved dispatched navigation function calls to mapDispatchToProps 2018-09-05 17:52:03 -04:00
Benjamin Wheeler
3c6530fe85
Merge pull request #2022 from benjiwheeler/account-nav-component
split account nav into its own component, pass logout callback to GUI
2018-09-05 13:32:45 -04:00
Ben Wheeler
f9003077a3 use account-nav class, not account-nav id 2018-09-04 17:15:52 -04:00
Linda
0f2ca09892 added Katelyn to credits page 2018-09-04 12:54:29 -04:00
Linda
d78ee1fe7c some linting 2018-08-30 15:44:17 -04:00
Linda
b0ecae351e prevented the project title from overflowing in a way more elegant way 2018-08-30 15:37:51 -04:00
Linda
591c792a5c Merge branch 'develop' of https://github.com/LLK/scratch-www into 1986/project-page/fit-title-length 2018-08-30 13:47:19 -04:00
chrisgarrity
39aa73c095
Merge pull request #2058 from LLK/hotfix/search-default-mode
[DEVELOP] Hotfix/search default mode
2018-08-30 11:12:34 -04:00
chrisgarrity
6722582994 Use popular for the default sort mode 2018-08-30 10:51:02 -04:00
chrisgarrity
17bf7c4061
Merge pull request #2044 from LLK/release/august-2018
[Master] Release for August 2018
2018-08-30 10:10:22 -04:00
Linda
affdc7e670 use specific class instead of h2 2018-08-28 17:01:36 -04:00
Linda
3863e9c5bf remove unnecessary comments 2018-08-28 16:50:34 -04:00
Linda
a1721abc46
Merge pull request #2042 from LiFaytheGoblin/2038/add-to-studio-dialog-entries-cursor
2038/add to studio dialog entries cursor
2018-08-28 17:41:44 -03:00
Linda
f10c811009
Merge pull request #2048 from LiFaytheGoblin/2047/project-page/white-space-next-to-comments
2047/project page/white space next to comments
2018-08-28 17:39:15 -03:00
Linda
c52eb610b4
Merge pull request #2041 from LiFaytheGoblin/1991/accessibility-extension-landing
1991/accessibility extension landing
2018-08-28 17:37:51 -03:00
Ray Schamp
e6ea1e301d
Merge pull request #2037 from LiFaytheGoblin/2016/add-to-studio-dialog-clip-studio-name
2016/add to studio dialog clip studio name
2018-08-28 16:08:29 -04:00
Linda
0ef4eca0bb improved wording 2018-08-28 09:33:06 -04:00
Ben Wheeler
733134c421 pass through logout callback to GUI 2018-08-27 18:56:27 -04:00
Eric Rosenbaum
a72f187b94 Add wedo troubleshooting item about updating scratch link 2018-08-27 12:17:59 -04:00
Linda
919910f30a made empty space next to comments section a bit smaller 2018-08-24 13:14:22 -04:00
Linda
10aa57e4a2 fixed ordering and so in css 2018-08-24 09:25:04 -04:00
Linda
d95ee37c04 now you can see the full title of something when hovering over the title which might be cut off 2018-08-24 09:09:17 -04:00
Linda
79e80aea54 improved remix and studio row 2018-08-24 09:05:08 -04:00
Linda
ba919062f3 changed look of studio thumbnails 2018-08-24 08:41:37 -04:00
Linda
befa5485bb some ordering of css stuff fixed 2018-08-23 14:31:44 -04:00
Linda
9db42fe9f4 prevented overflowing project title in a nice looking way 2018-08-23 14:24:31 -04:00
Ben Wheeler
796ad7b152 split account nav into its own component 2018-08-23 14:10:55 -04:00
Linda
50242a3bb1 added pointer cursor style to the buttons that add or remove a project to or from a studio 2018-08-23 11:32:18 -04:00
Linda
f934b9bc7e fixed some intendation 2018-08-23 11:18:12 -04:00
Linda
b3b0843b75 some improvements and added alt attributes for microbit 2018-08-23 11:05:38 -04:00
Linda
4635ae3b82 added alt tags to wedo page 2018-08-23 10:38:49 -04:00
Eric Rosenbaum
f51f6801e6 Add wedo troubleshooting item about updating scratch link 2018-08-23 10:03:02 -04:00
Linda
641e9895f6 updated from develop with new extension landing pages 2018-08-22 18:05:57 -04:00
Linda
56d9ac2af9 resolve travis errors caused by wrong ordering of css stuff 2018-08-22 16:48:07 -04:00
Eric Rosenbaum
78b32597c5
Merge branch 'develop' into hotfix/extension-landing-pages 2018-08-22 16:28:52 -04:00
Ray Schamp
7851789f9f
Merge pull request #2001 from kyleplo/patch-2
Add sort scheme dropdown to search results page
2018-08-22 15:59:25 -04:00
Linda
68c7616a25 remove now obsolete truncate library 2018-08-22 15:10:19 -04:00
Linda
a7c279fab5 cut of studio name on studio adding dialog using css and not using the library for that anymore, also displays full title as a title of the div 2018-08-22 15:05:21 -04:00
kyleplo
d7feb51695
Fix non-existent term 2018-08-22 14:50:19 -04:00
kyleplo
d2721f0bbc
Fix getting query 2018-08-22 14:43:00 -04:00