Commit graph

1258 commits

Author SHA1 Message Date
picklesrus
378cebe5f4 Take user to the homepage when finishing the join flow (unless they came from the editor). There is replication lag that makes creating a project immediatley a bad experience. We'll fix this in a followup. 2019-11-15 11:23:54 -05:00
picklesrus
a036d5d13c Put the right value in the password field. This got mixed up in #3512. 2019-11-13 10:10:14 -05:00
Ben Wheeler
48d7209942 remove truncation of password, passwordConfirm 2019-11-12 11:43:23 -05:00
picklesrus
3ad17a4572 Add privacy policy and link to the email step. 2019-11-06 12:32:55 -05:00
picklesrus
b845010025
Merge pull request #3503 from picklesrus/join-ga
Add analytics logging to join flow.
2019-11-06 11:01:40 -05:00
Benjamin Wheeler
7cea138c46
Merge pull request #3505 from LLK/revert-3495-revert-3468-country-data-name-fix
Revert "Revert "fixed country options to use full country name string as option value""
2019-11-06 10:22:31 -05:00
picklesrus
68fc4fe45b Fix merge conflicts :( 2019-11-05 20:01:35 -05:00
picklesrus
c77db39062 Guard calls to componentDidMount with a check for existence.
Fix tag on username step.
2019-11-05 19:50:42 -05:00
picklesrus
30967a3056 Set sendAnalytics to be required and send the right props to the error step. Also add a test for the error step. 2019-11-05 19:50:42 -05:00
picklesrus
e4b79c1bd2 Add analytics logging to join flow. Adding page views for each step in the flow. 2019-11-05 19:48:44 -05:00
Ben Wheeler
7b69935d50 in join flow, use country name options 2019-11-05 18:31:05 -05:00
Ben Wheeler
3e7753691f use country code options in regular registration 2019-11-05 18:30:49 -05:00
Benjamin Wheeler
77fca39bbf
Merge pull request #3485 from benjiwheeler/join-flow-cache-ignores-api-failures
username step and email step caches ignore api failures
2019-11-05 12:51:33 -05:00
Ben Wheeler
7b2e75821c revise function names and handling of registration errors 2019-11-05 12:12:03 -05:00
Ben Wheeler
e3d3d97c19 change p tags to divs; set isRequired on canTryAgain 2019-11-05 12:12:03 -05:00
Ben Wheeler
510906e538 removed stray onCaptchaError from bind list 2019-11-05 12:12:03 -05:00
Ben Wheeler
f713298d37 use class instead of id for identifying errorMsg in test 2019-11-05 12:11:04 -05:00
Ben Wheeler
d265ad3d44 show errorMsg content, not formatted message with errMsg as id 2019-11-05 12:11:03 -05:00
Ben Wheeler
469db4dc36 simplify canTryAgain function, reset registrationError on retry 2019-11-05 12:11:03 -05:00
Ben Wheeler
9a97285ac6 rename handleRegistrationError to handleCaptchaError 2019-11-05 12:11:03 -05:00
Ben Wheeler
a95d17f708 refactor error handling in join flow 2019-11-05 12:09:56 -05:00
Ben Wheeler
ceb3af1c58 improve formatting of welcome, error step text 2019-11-05 12:09:56 -05:00
Ben Wheeler
517d8ff7cc registration error step takes different props 2019-11-05 12:09:56 -05:00
Ben Wheeler
b6fcffd6f3 correct misspelled join flow intl id 2019-10-31 23:21:21 -04:00
Nandakumar Edamana
f54cf1a639 fixed a margin issue caused by the previous fix 2019-10-27 17:07:43 +05:30
Nandakumar Edamana
4e3956e1e4 fixed the issue "Create a Username" has different font weight 2019-10-27 16:57:55 +05:30
Ben Wheeler
49fe86ae3c username step and email step caches ignore api failures 2019-10-23 17:02:57 -04:00
Benjamin Wheeler
d9bd2baf15
Merge pull request #3424 from benjiwheeler/join-flow-splash-join-button
splash page join button works with new join flow
2019-10-21 12:18:01 -04:00
Benjamin Wheeler
fdbbc5e632
Merge pull request #3423 from benjiwheeler/join-flow-select-text
make text selectable, so users can copy errors
2019-10-21 11:17:02 -04:00
Ben Wheeler
c499624345 make text selectable, so users can copy errors 2019-10-18 13:54:59 -04:00
Ben Wheeler
baa4e0e2c3 refactor intro.jsx and navigation.jsx to use new navigation reducer single registration open request action 2019-10-17 23:38:54 -04:00
Ben Wheeler
ed99e410f5 splash page join button works with new join flow 2019-10-17 23:38:54 -04:00
Ben Wheeler
0dfd1cf9fc added comment about setting initial state 2019-10-17 23:34:31 -04:00
Ben Wheeler
eeb9f03887 use initialState to set, reset state of join-flow component 2019-10-17 23:32:06 -04:00
Ben Wheeler
3469f17bfe error step can show try again, or start over; limits to one retry 2019-10-17 22:25:00 -04:00
Ben Wheeler
8b78fcb8db always load captcha on email step 2019-10-17 22:22:44 -04:00
Benjamin Wheeler
3e6e87c3a4
Merge pull request #3417 from benjiwheeler/join-flow-cache-remote
Join flow cache remote
2019-10-17 08:23:47 -04:00
Benjamin Wheeler
f271a4f0c3
Merge pull request #3444 from benjiwheeler/join-flow-sentry-wrap
Add Sentry to Join Flow; set Sentry tags on various ErrorBoundaries
2019-10-16 16:34:43 -04:00
Benjamin Wheeler
6b6b415069
Merge pull request #3434 from benjiwheeler/join-flow-responsive-more
Join flow responsive changes for input, button and select widths
2019-10-16 16:19:50 -04:00
Ben Wheeler
226134bc81 renamed ErrorBoundary prop name to componentName 2019-10-11 17:17:50 -04:00
Benjamin Wheeler
757ac80677
Merge pull request #3427 from benjiwheeler/join-flow-autocomplete-3
turn off automplete and autocorrect for join-flow inputs
2019-10-11 16:28:25 -04:00
Benjamin Wheeler
14c6211614
Merge pull request #3435 from benjiwheeler/join-flow-image-bg-color
Join flow image preview using background color
2019-10-11 16:27:48 -04:00
Ben Wheeler
91a05d636f redo sentry tag key and values, move ErrorBoundary around embed 2019-10-10 13:15:35 -04:00
Ben Wheeler
cd73afee1b use ‘scratch-www’ rather than ‘www’ in report to sentry 2019-10-09 23:05:23 -04:00
Ben Wheeler
fbbf467878 set ‘www’ as tag, rather than environment 2019-10-09 22:48:11 -04:00
Ben Wheeler
54f30fc944 set errorboundary name tag everywhere ErrorBoundary is used 2019-10-09 22:30:59 -04:00
Ben Wheeler
0f8eb638cc add support in ErrorBoundary for setting errorboundary tag 2019-10-09 22:30:35 -04:00
Ben Wheeler
e45397d250 custom birth month and year width for small window sizes 2019-10-07 16:51:00 -04:00
Ben Wheeler
abc85fe3be change calculation for join flow modal inner content width, to be more friedly at small sizes 2019-10-07 16:51:00 -04:00
Ben Wheeler
5b60366985 change how we handle the width of gender custom input 2019-10-07 16:51:00 -04:00
Benjamin Wheeler
3a06ad81b1
Merge pull request #3425 from benjiwheeler/join-flow-truncate-custom-gender
truncate custom gender, and other inputs
2019-10-07 12:47:58 -04:00
Benjamin Wheeler
60609dc819
Merge pull request #3430 from benjiwheeler/join-flow-responsive-fixes
Join flow responsive fixes
2019-10-07 12:44:30 -04:00
Benjamin Wheeler
0985124f8b
Merge pull request #3431 from benjiwheeler/join-flow-adjust-email-centering
adjust join flow email centering
2019-10-07 12:43:45 -04:00
Ben Wheeler
868fb0f044 fix join flow header image height, so color background will be completely covered 2019-10-03 19:26:41 -04:00
Ben Wheeler
e27a7cdbbc pass join flow image background classes through to relevant steps 2019-10-03 19:25:56 -04:00
Ben Wheeler
6da150d02e add background styles for join flow images 2019-10-03 19:24:43 -04:00
Ben Wheeler
2b23a41a45 several fixes to join modal responsiveness 2019-10-03 12:35:36 -04:00
Chris Garrity
916be715c1 Other Scratch app changes
* Footer
* ideas page
* FAQ
* parents
2019-10-02 16:38:38 -07:00
Chris Garrity
54c5484263 Copy changes for Download page. 2019-10-02 15:57:06 -07:00
Ben Wheeler
17c1a257aa adjust email centering 2019-10-02 18:29:28 -04:00
Ben Wheeler
644aa272b3 turn off automplete and autocorrect for join-flow inputs 2019-10-01 18:38:47 -04:00
Benjamin Wheeler
28fd111199
Revert "turn off automplete and autocorrect for join-flow inputs" 2019-10-01 18:34:19 -04:00
Ben Wheeler
5db507201a truncate username, passwords, and email to their max stored lengths 2019-10-01 18:15:38 -04:00
Ben Wheeler
825c613db8 truncate custom gender to 25 chars long 2019-10-01 18:04:47 -04:00
Ben Wheeler
62fc3457e7 turn off automplete and autocorrect for join-flow inputs 2019-10-01 16:43:33 -04:00
Benjamin Wheeler
a47e1c9898
Merge pull request #3418 from benjiwheeler/join-flow-move-modal-down
move join flow modal down in small window widths
2019-09-30 17:02:46 -04:00
Benjamin Wheeler
d4d4adc9f9
Merge pull request #3362 from benjiwheeler/join-flow-spinner-simple
format and update timing of join flow spinner
2019-09-30 16:49:52 -04:00
Benjamin Wheeler
fdeb87fce9
Merge pull request #3383 from benjiwheeler/join-flow-navigate-to-join-page
scratch3 join flow redirects to /join, outside editor
2019-09-30 16:44:24 -04:00
Benjamin Wheeler
aabdd128f4
Merge pull request #3416 from benjiwheeler/join-flow-show-password-default
change password default; remove unused state var
2019-09-30 16:43:50 -04:00
Ben Wheeler
0656ab6a9e added simple memoizing cache for email step 2019-09-30 13:29:17 -04:00
Ben Wheeler
3bc6e7ff6f revised comments 2019-09-30 13:29:17 -04:00
Ben Wheeler
0d4d6a9adc cache remote username check response 2019-09-30 13:29:17 -04:00
Benjamin Wheeler
3c5313d8ce
Merge pull request #3415 from benjiwheeler/join-flow-validation-semi-bold
make validations semi-bold
2019-09-30 13:21:29 -04:00
Ben Wheeler
484cf46b8c move join flow modal down in small window widths 2019-09-30 11:49:04 -04:00
Ben Wheeler
3bee3fae4b change password default; remove unused state var 2019-09-26 14:51:33 -04:00
Ben Wheeler
51c816c5cf make validations semi-bold 2019-09-26 14:49:42 -04:00
Ben Wheeler
2efb3a7bfa join flow bold text and related design tweaks 2019-09-26 14:46:42 -04:00
Paul Kaplan
db8cc6f80f Make app store links open in a new tab 2019-09-26 10:43:36 -04:00
Ben Wheeler
6ff1a1c4f1 add navigation test 2019-09-26 09:29:02 -04:00
Paul Kaplan
a9a175b3cb
Merge pull request #3384 from benjiwheeler/join-flow-gender-strings
gender step uses blank default, lcase values
2019-09-25 16:04:58 -04:00
Paul Kaplan
32165c0d31
Merge pull request #3397 from paulkaplan/chromeos-feature-flag
Download and initial extension pages for forthcoming ChromeOS app launch
2019-09-25 16:00:06 -04:00
Ben Wheeler
ccffa35037 change gender string defaults 2019-09-25 09:57:40 -04:00
Ben Wheeler
6fc5705779 revise country placeholder 2019-09-24 20:16:48 -04:00
Ben Wheeler
7e86319a36 wired showCloseButton through new join flow 2019-09-24 18:43:29 -04:00
Ben Wheeler
691faabe28 pass createProjectOnComplete prop through join flow
…so welcome step can display correct completion text
2019-09-24 18:41:24 -04:00
Paul Kaplan
762dc324b8 Update extension pages for new OS picker 2019-09-24 16:25:58 -04:00
Paul Kaplan
5d39e59dd5 Use a feature flag to contain new Scratch Desktop updates 2019-09-24 15:17:11 -04:00
picklesrus
0d60b64c39 Add a prop to Modal that allows you to hide the close button. Set it to show by default and have the standalone join flow page set it to hidden. 2019-09-24 13:43:34 -04:00
Benjamin Wheeler
c609d99e0e
Merge pull request #3386 from benjiwheeler/join-flow-disable-click-outside
new join flow modal stays open on click outside
2019-09-24 12:10:56 -04:00
Benjamin Wheeler
0e13c2dd48
Merge pull request #3392 from benjiwheeler/join-flow-validation-positioning
Join Flow validation positioning/spacing fixes
2019-09-24 12:10:25 -04:00
Benjamin Wheeler
779520aa2a
Merge pull request #3395 from benjiwheeler/join-flow-responsive-validation
make validations be the same width as inputs…
2019-09-24 12:09:43 -04:00
Benjamin Wheeler
117f0cee91
Merge pull request #3394 from benjiwheeler/join-flow-drag
set modal close icon to draggable false
2019-09-24 09:29:23 -04:00
picklesrus
5f3d6506c0
Merge pull request #3367 from picklesrus/captcha-error-handling
Handle errors of captcha loading by setting error state on JoinFlow.
2019-09-23 23:57:13 -04:00
Ben Wheeler
e901deb398 make validations be the same width as inputs…
…when window is narrow
2019-09-23 16:26:34 -04:00
Ben Wheeler
d4c791adfb set modal close icon to draggable false 2019-09-23 15:16:20 -04:00
Ben Wheeler
865e0a09dd give join-flow validations more spacing from inputs they refer to; unset width of Required message 2019-09-23 13:23:38 -04:00
Ben Wheeler
693c8e11e3 new join flow modal stays open on click outside 2019-09-23 10:36:58 -04:00
Benjamin Wheeler
ecdfaeeeec
Merge pull request #3361 from benjiwheeler/join-flow-dropdown-validation
when select dropdown is focused, clear any validation errors
2019-09-23 09:56:19 -04:00
Ben Wheeler
d905f624ca gender step uses blank default, lcase values 2019-09-20 18:22:15 -04:00
Ben Wheeler
106ccb34c6 make gender step height more flexible 2019-09-20 17:54:45 -04:00