Commit graph

948 commits

Author SHA1 Message Date
Ray Schamp
a9039ca63b Only redirect approved educators to My Classes
Fixes #800
2016-08-02 10:52:47 -04:00
Ray Schamp
0e8e842eb2 Lint 2016-08-02 09:50:46 -04:00
Matthew Taylor
85377193a8 Merge pull request #796 from mewtaylor/isseu/gh-792
[Develop] Hotfix: Create space between paragraph elements
2016-08-02 09:37:27 -04:00
Matthew Taylor
5cbaabbe97 Merge pull request #791 from mewtaylor/hotfix/conference-livestream
[Develop] Hotfix: Add hyperlink to keynote livstream for 2016 conf
2016-08-02 09:37:16 -04:00
Technoboy10
63c67a1d2d use frameless.js for carousel breakpoints 2016-08-02 09:17:13 -04:00
Matthew Taylor
2e962c7831 Create space between paragraph elements
Fixes #792
2016-08-01 14:21:27 -04:00
Ray Schamp
c842d06ac4 Add "Request Account" button to Educators landing 2016-08-01 12:19:29 -04:00
Ray Schamp
025958fc24 Add align prop to SubNavigation component 2016-08-01 12:18:25 -04:00
Matthew Taylor
00e6ad2ee1 Add hyperlink to keynote livstream for 2016 conf 2016-08-01 10:59:27 -04:00
Technoboy10
6b63f5b7ad set image width to 100% 2016-07-29 17:37:24 -04:00
Matthew Taylor
4909d509d2 remove ie fallback to mobile styling
it looks like @rschamp’s wodnerful `top` alignment fix for Chrome and Edge also helps here, from a test I did in IE11.
2016-07-28 15:46:56 -04:00
Matthew Taylor
d97bc193df Remove unnecessary redefinitions
These are already defined in the base, and are not overridden anywhere. Only redefine the things that were overridden.
2016-07-28 15:11:14 -04:00
Matthew Taylor
2c9df3237e Fix gender input error alignment in IE11
Also re-apply the arrow styling on the organization checkbox group, since it appears to be aligned correctly.
2016-07-28 14:10:36 -04:00
Ray Schamp
e218cc5169 Move "select country" to general strings
It's reused in the other registration views so doesn't belong in teacherregistration/l10n.json

Fixes #783
2016-07-28 12:26:56 -04:00
Matthew Taylor
9e9ffc96e9 Merge pull request #779 from mewtaylor/issue/gh-773
Fix GH-[772,773]: Fix “afterschool” typo, default country and margin for username
2016-07-28 10:52:55 -04:00
Ray Schamp
7e8fddef18 Don't use a static width for inputs
Fixes #769
2016-07-28 10:39:18 -04:00
Matthew Taylor
40fb433d7d Make country choice a function that’s called
And also default the country in address to the country in demographics. Thanks @rschamp @carljbowman!
2016-07-28 09:56:01 -04:00
Matthew Taylor
2650e6e148 Move countryOptions to the global scope
thanks @rschamp!
2016-07-28 08:30:29 -04:00
Matthew Taylor
cf4a057278 Fix “afterschool” typo
Also make default country selectable in the user demographic step, and fix the spacing with `Create a Username`
2016-07-27 23:33:45 -04:00
Ray Schamp
668f141457 Merge pull request #778 from rschamp/bugfix/chrome-52
Set common y-origin for validation bubbles
2016-07-27 20:17:32 -04:00
Ray Schamp
ecbbeb5612 Set common y-origin for validation bubbles
I believe this will keep the misalignment from happening across browsers. Sets the top left corner to the top left corner of the input block.

Resolves #770
2016-07-27 20:15:53 -04:00
Ray Schamp
19d67dc0b4 Resurrect old invite step design for new users 2016-07-27 19:32:08 -04:00
Technoboy10
2da07923ca revert verbiage change as per IRL discussion with Carl 2016-07-27 15:49:48 -04:00
Ray Schamp
27a7b98ab9 Merge pull request #765 from rschamp/bugfix/752
Redesign invite step, add option to log out
2016-07-27 14:37:45 -04:00
Ray Schamp
89071b10d0 Lint 2016-07-27 14:12:55 -04:00
Ray Schamp
0b1f708400 Don't redirect to password reset on complete_registration 2016-07-27 10:27:31 -04:00
Ray Schamp
d1f73c3ef4 Redesign invite step, add option to log out
Resolves #752
2016-07-27 10:24:37 -04:00
Technoboy10
26d314a5c1 undo weird merge thing that happened a while back 2016-07-27 09:54:07 -04:00
Technoboy10
5e7bf85733 remove redundant media query from footer.scss 2016-07-27 09:48:07 -04:00
Ray Schamp
2b1cf25f88 Merge pull request #763 from rschamp/bugfix/3878
Redirect students that must reset their password
2016-07-27 09:35:19 -04:00
Technoboy10
0d2416c850 fix merge conflicts 2016-07-27 09:33:15 -04:00
Technoboy10
90631b3054 remove dev file 2016-07-27 09:27:22 -04:00
Technoboy10
25402113bf tweak a few things before WIP PR 2016-07-27 09:26:33 -04:00
Matthew Taylor
806fd25e46 Move to the view
thanks @rschamp!
2016-07-26 17:03:41 -04:00
Ray Schamp
d83df730c8 Redirect students that must reset their password
Fixes LLK/scratchr2#3878
2016-07-26 16:40:05 -04:00
Technoboy10
ae9c15f6ce update with routes.json from develop branch 2016-07-26 15:51:05 -04:00
Matthew Taylor
60a62bb374 Redirect to /educators/classes if a confirmed teacher
Fixes #757. Note: Because we are getting this info from the session, the redirect may not happen until the page is rendered first in cases where the connection is slow, or the db is slow.
2016-07-26 15:24:51 -04:00
Matthew Taylor
1c7dc73ed7 Merge pull request #753 from mewtaylor/issue/gh-749
Fix GH-749: Fix formatting for a few form elements
2016-07-26 11:42:13 -04:00
Technoboy10
2a5f330884 hide intro if not desktop width 2016-07-26 11:29:45 -04:00
Matthew Taylor
e87a2bce76 remove trailing whitespace 2016-07-26 11:24:51 -04:00
Technoboy10
a8b26b1a1c experiment with removing content display from scss 2016-07-26 11:06:21 -04:00
Matthew Taylor
69ac5b60bd make .no-label an auto assignment
thanks @rschamp!
2016-07-26 10:44:19 -04:00
Matthew Taylor
b510d154df remove ‘noformsy` option on inputs 2016-07-26 10:20:06 -04:00
Matthew Taylor
6787ae03ce Apply classes to row, not textarea
And move help rendering into the phone input row.
2016-07-26 08:06:38 -04:00
Ray Schamp
74f56d42c5 Explicitly show a spinner while loading class data
To make this view work consistently with the complete registration view
2016-07-25 16:59:55 -04:00
Ray Schamp
4df4ea8930 Show an error to logged out users
When logged out users visit the complete registration view, show them an error rather than a spinner.
2016-07-25 16:58:38 -04:00
Matthew Taylor
d8e07ee7f6 use rowClassName instead
so that it can include `label`. Also add some default styling to `label` in `.row`. Thanks @rschamp!
2016-07-25 15:43:44 -04:00
Matthew Taylor
263d292b3c Fix formatting for a few form elements
and make use of the FRC `elementWrapperClassName`, since they way we did it before – custom `className` strings on the element – was not working. Fixes #749.
2016-07-25 13:21:28 -04:00
Ray Schamp
61e21f6b5b Show an error if the API doesn't return class data
Fixes #747.

Also explicitly show a spinner when the component is waiting on the class API, and hide it when it returns.
2016-07-25 11:41:10 -04:00
Technoboy10
daf803d4a3 experiment with the react-responsive library 2016-07-25 10:53:57 -04:00
Technoboy10
188841c73c layout reducer (needs work) 2016-07-22 14:57:47 -04:00
Technoboy10
808922b50d pass layout to navbar and footer 2016-07-22 14:57:05 -04:00
Technoboy10
391344489d footer mobile 2016-07-22 14:56:14 -04:00
Technoboy10
5b9cef8dd6 navbar mobile 2016-07-22 14:55:56 -04:00
Technoboy10
a9def9c1ae tweak splash to not be terrible on mobile 2016-07-22 14:53:39 -04:00
Ray Schamp
62609cbc87 Collapse by beginning all routes with a common ^ 2016-07-22 12:38:24 -04:00
Ray Schamp
eba654c411 Collapse /classes routes to shorten condition 2016-07-22 12:21:42 -04:00
Ray Schamp
7455807591 Provide RegistrationError content as children
This allows us to do more inline formatting, so we don't have any of that outside of `render`.

Thanks @mewtaylor
2016-07-22 09:38:37 -04:00
Ray Schamp
be41d004ad Show password by default 2016-07-21 21:08:07 -04:00
Ray Schamp
3335207c54 Update copy for password step 2016-07-21 21:08:07 -04:00
Ray Schamp
7e330bfb67 Redirect to student registration update view
Previously requests to /session/ would return a signal to redirect, but we need /session/ to complete registration. So check if we should redirect when we retrieve the session.

Also update this behavior for banned users.
2016-07-21 21:08:07 -04:00
Ray Schamp
a4dd1611d1 Add student registration update view 2016-07-21 21:08:06 -04:00
Ray Schamp
1df6eb5d2a Update incorrect CSS class name 2016-07-21 21:08:06 -04:00
Ray Schamp
7a6e5c3eb4 Fix student registration localization
Add missing strings, actually translate the content of the steps
2016-07-21 21:08:06 -04:00
Ray Schamp
8dae646ff3 Style tweaks 2016-07-21 20:44:51 -04:00
Ray Schamp
b06a9e49d0 Fix wording on student username step 2016-07-21 20:44:51 -04:00
Ray Schamp
9aa7e828b7 Remove "blank" classroom, show spinner instead
It was broken due to a key error on `classroom.images` anyway
2016-07-21 20:44:51 -04:00
Ray Schamp
8038fbcdc1 Fix classroom API call 2016-07-21 18:10:41 -04:00
Andrew Sliwinski
74b26267d2 Merge pull request #741 from thisandagain/bugfix/740
Adjustments to the educators page as per feedback
2016-07-21 13:49:37 -04:00
Andrew Sliwinski
99c61ef0f7 Adjustments to the educators page as per feedback. Resolves GH-740 2016-07-21 13:43:35 -04:00
Matthew Taylor
859877c1ff refresh session on successful registration
This is needed to ensure that the approval step displays the correct “Wait for Approval” message. Fixes #698
2016-07-21 12:57:49 -04:00
Matthew Taylor
102de9a087 Merge branch 'develop' of https://github.com/LLK/scratch-www into issue/gh-715
* 'develop' of https://github.com/LLK/scratch-www:
  Pluralize example headlines on educators page
  Educator page language adjustments as per feedback. Resolves GH-734
  fix typo
  Update image format for API change
  Fix lint errors, l10n issues
  revert irrelevant change
  Remove IE weird input additions, fallback to mobile error style on IE, fix some mobile error issues
  Update description of demographics step
  Add student registration flow
  Scope message strings more reusably
  Make registration styles reusable
  Parse with babel-eslint
  Fix whitespace

# Conflicts:
#	src/l10n.json
2016-07-21 10:27:10 -04:00
Connor Hudson
6a58c7b2e6 Merge pull request #731 from technoboy10/ie-validation-fallback
Fix GH-699: Fallback to mobile validation bubble on IE
2016-07-21 10:24:25 -04:00
Technoboy10
b88b8c83b1 redo responsive nav 2016-07-21 10:12:16 -04:00
Andrew Sliwinski
4f6c071c2c Pluralize example headlines on educators page 2016-07-21 08:41:31 -04:00
Andrew Sliwinski
4d2f9d7a05 Educator page language adjustments as per feedback. Resolves GH-734 2016-07-20 17:53:02 -04:00
Technoboy10
3bbc17bb35 moved ie targeting to steps.scss 2016-07-20 17:29:34 -04:00
Technoboy10
22dc55c030 change verbiage, begin work on responsive nav/footer 2016-07-20 16:53:50 -04:00
Ray Schamp
d3f1046a42 Merge pull request #730 from rschamp/feature/3679-student-flow
Add student registration flow
2016-07-20 15:57:47 -04:00
Technoboy10
74afd163b5 fix typo 2016-07-20 14:28:46 -04:00
Ray Schamp
754859f35f Update image format for API change
Removed default `image` field convention
2016-07-20 13:47:43 -04:00
Ray Schamp
a3b56dcbf1 Fix lint errors, l10n issues 2016-07-20 12:07:19 -04:00
Technoboy10
285c4c2d69 revert irrelevant change 2016-07-20 09:58:37 -04:00
Technoboy10
4e6efae667 Remove IE weird input additions, fallback to mobile error style on IE, fix some mobile error issues 2016-07-20 09:46:51 -04:00
Ray Schamp
6d5b7d3c02 Update description of demographics step 2016-07-19 22:58:50 -04:00
Matthew Taylor
90a4277a8a Change copy for Wait for Approval
Fixes #715
2016-07-19 16:54:38 -04:00
Ray Schamp
1c5940cc05 Add student registration flow 2016-07-19 16:51:28 -04:00
Ray Schamp
47ebef1b6f Scope message strings more reusably 2016-07-19 16:51:10 -04:00
Ray Schamp
67ecb60f48 Make registration styles reusable 2016-07-19 16:49:12 -04:00
Ray Schamp
5b6a1fe8b9 Fix whitespace 2016-07-19 09:24:07 -04:00
Connor Hudson
637b1352cd Merge pull request #727 from technoboy10/gh674-ie11-card-margin
Fix GH-674: Waiting room cards should be centered in IE
2016-07-18 11:16:07 -04:00
Technoboy10
8c260032fa card margin auto 2016-07-18 10:39:13 -04:00
Technoboy10
db049b871f fix IE11 select background, indent issues 2016-07-18 10:17:22 -04:00
Matthew Taylor
7741cb2c7e Merge pull request #685 from St19Galla/patch-1
Fix gh-684 - Changing error message
2016-07-12 19:04:16 -04:00
Matthew Taylor
6fd1d08d56 Merge pull request #720 from mewtaylor/issue/usernames-search
[Develop] GH-710: only show username in search and explore
2016-07-11 20:21:58 -04:00
Matthew Taylor
27b5afddfb Forgot search
thanks @thisandagain!
2016-07-11 19:59:13 -04:00
Matthew Taylor
845ddb2966 only show username in search and explore
fixes #710
2016-07-11 16:35:03 -04:00
Andrew Sliwinski
f8ee125bfe Update job listings 2016-07-11 16:16:46 -04:00
Matthew Taylor
d8a0436525 Forgot a few 2016-07-11 11:09:15 -04:00
Matthew Taylor
87a0350b02 Allow urls with ajax to pass through
Needed for https://github.com/LLK/scratchr2/pull/3804
2016-07-11 10:29:22 -04:00
Matthew Taylor
075f1481a2 Add custom validation for organization and phone
It appears that the `required` field is not applied in the way we'd like it to be for the custom checkbox group and custom phone input fields, so do a `required` check on form submission. Additionally, this adds in a few style fixes. Fixes #695, #694, #693, #691
2016-07-07 16:56:51 -04:00
St19_Galla
ea6cd2ab2c final fix 2016-07-07 14:18:16 -04:00
Matthew Taylor
7f466aacc6 Add language to search / explore api requests
Fixes #686, thanks @thisandagain !
2016-07-07 08:38:10 -04:00
St19_Galla
16a985212c alphanumeric only text fix 2016-07-06 21:20:46 -04:00
Technoboy10
717a2319b4 remove button, use div instead 2016-07-06 14:16:08 -04:00
Technoboy10
66c3a02340 default cursor on coming soon, make cards into links 2016-07-06 12:27:42 -04:00
Ray Schamp
b7c46f483e Don't error on null children
Was throwing a `TypeError` when child was null/undefined.
2016-07-05 15:48:21 -04:00
Ray Schamp
c50ac03a48 Merge pull request #671 from rschamp/bugfix/669
Disable default style for select elements in IE
2016-07-05 14:39:58 -04:00
Ray Schamp
edf0c1e475 Disable default style for select elements in IE
Fixes #669
2016-07-05 14:39:08 -04:00
Matthew Taylor
9a037fda81 don't use let yet for variable definitions
Fixes #670
2016-07-05 14:21:40 -04:00
Ray Schamp
6f9c16a7a5 Merge pull request #667 from rschamp/bugfix/647
Add style to general error messages
2016-07-05 14:18:49 -04:00
Matthew Taylor
0d23964771 Merge pull request #664 from mewtaylor/issue/gh-628-focusout
Fix GH-628: Add box shadow for focus state on checkboxes
2016-07-05 14:02:51 -04:00
Matthew Taylor
aa3cbe552a Make category options into key/value
so that we can store the query string with the tab name, since it's not the same in every instance. fixes #666, and makes a couple other style tweaks.
2016-07-05 13:38:51 -04:00
Ray Schamp
d990dee755 Move location of the general error message
From review of the style with @carljbowman

Requires a bit of magic, where the Form component manually adds the "all" value. But without a major overhaul of the validation system, I don't see how else to put the general error among the other fields.
2016-07-05 12:06:10 -04:00
Ray Schamp
b15b5b8614 Add style to general error messages
Resolves #647
2016-07-05 12:03:27 -04:00
Matthew Taylor
2cd8019ef6 Add box shadow for focus state on checkboxes
Fixes #628 by applying the same outline for focus as is currently applied to checked boxes.
2016-07-05 11:39:06 -04:00
Ray Schamp
11155c429e Merge pull request #661 from rschamp/bugfix/654
Fix JSON response parsing in IE
2016-07-04 09:23:28 -04:00
Ray Schamp
b89d644573 Fix JSON response parsing in IE
Fixes #654

IE does not honor responseType: 'json', and will not parse responses as JSON unless json data is present in the request. For some reason this issue can also be solved by including a `json` attribute on the xhr request, but if that's present, url encoded form data is overwritten with the contents of the json.  So just try to parse the response ourselves if it looks like it wasn't parsed.

See https://github.com/Raynos/xhr/issues/123
2016-07-03 15:54:58 -04:00
Ray Schamp
7fe82c11be Get rid of most splash warnings in development 2016-07-03 14:49:01 -04:00
Ray Schamp
c25852b3c6 Merge pull request #657 from rschamp/bugfix/645
Revalidate address step after invalid submissions
2016-07-01 13:48:13 -04:00
Ray Schamp
a56f994886 Revalidate address step after invalid submissions
I don't like that the state is being set to a calculation of existing props. When I did that calculation in `render`, it didn't update when fields were changed.

Fixes #645
2016-07-01 11:43:18 -04:00
Connor Hudson
d432282ff4 Merge pull request #652 from technoboy10/gh649-z-index-weirdness
Fix GH-649: Dropdown hidden by TED Talk
2016-07-01 08:40:54 -04:00
Technoboy10
2206cb97f6 message icon tweak 2016-06-30 19:17:53 -04:00
Technoboy10
42c000d14f orangify this 2016-06-30 18:06:17 -04:00
Matthew Taylor
6db426a586 Use empty default object
Looks as if the having one of these objects as the default causes overwriting in some way, as opposed to augmentation. Have the source object be an empty one, so that it gets the attributes of both defaults and props. Fixes #642.
2016-06-30 16:52:46 -04:00
Technoboy10
5e5c2a4f9d Remove z-index as it wasn't needed 2016-06-30 16:46:44 -04:00
Ray Schamp
5b288e4d3e Merge pull request #648 from rschamp/feature/username-clarity
Clarify username field is not for logging in
2016-06-30 16:17:14 -04:00
Ray Schamp
0816b0ec0f Clarify username field is not for logging in 2016-06-30 16:16:31 -04:00
Connor Hudson
7f3af0f8be Merge pull request #639 from technoboy10/gh637-relativepaths
Fix GH-637: Make links to help and tips window relative
2016-06-30 15:57:43 -04:00
Ray Schamp
a0a82ef5a7 Merge pull request #646 from rschamp/bugfix/608
Fix localization of address validation message
2016-06-30 15:55:26 -04:00
Ray Schamp
554e21cd15 Fix localization of address validation message
Fixes #608
2016-06-30 15:54:32 -04:00
Matthew Taylor
5cc6eb3ecb use empty string if no cookie value found
redux doesn't like getting null values for actions, so give empty ones

/cc @rschamp
2016-06-30 15:29:53 -04:00
Matthew Taylor
300831c1e1 Merge pull request #641 from mewtaylor/issue/gh-636-tfaq-link
Fix GH-636: point landing page to teacher faq page
2016-06-30 13:48:57 -04:00
Matthew Taylor
2017e1573d point landing page to teacher faq page
Fixes #636
2016-06-30 13:37:12 -04:00
Matthew Taylor
04aa7e01ef check for the null value in get
thanks @rschamp!
2016-06-30 11:40:05 -04:00
Matthew Taylor
794c3e2cba Set null contents to null instead of error throw
Before, if a cookie didn't exist, it would throw an error, not causing permissions/tokens to change to empty values. This fixes that (and #626) by setting the value to undefined instead.
2016-06-30 11:27:46 -04:00
Technoboy10
b5bf0298d7 Make s.m.e links relative 2016-06-30 10:06:10 -04:00
Technoboy10
088eb7cc66 inherit width on iframe 2016-06-30 09:46:39 -04:00
Technoboy10
b0f0bce211 enable fullscreen, fix border radius and aspect ratio 2016-06-30 09:43:24 -04:00
Matthew Taylor
f2b8e9025d switch ordering in defaults
This was assigning `props` to defaults, rather than the other way around. Fixes #618.
2016-06-30 08:00:40 -04:00
Matthew Taylor
b874d05bda Override devault input style for login
so that it looks like it used to, and not to tall. Fixes #618.
2016-06-29 14:54:00 -04:00
Matthew Taylor
9fb6170569 style error-step like last-step
Since they're both mostly info cards. Fixes #627.
2016-06-29 14:08:16 -04:00
Connor Hudson
9bafdf6067 Merge pull request #619 from technoboy10/darken-dropdown
Darken Account Nav Link when Menu Open
2016-06-29 13:31:27 -04:00
Technoboy10
41d9b1f526 use classNames before return 2016-06-29 13:24:37 -04:00
Matthew Taylor
8f60b020cb fix educator faq link
`info` is not in there anymore
2016-06-29 12:35:53 -04:00
Matthew Taylor
19bbd5ae7b Link icon to splash page
fixes #623
2016-06-29 10:53:55 -04:00
Connor Hudson
42ccc6c0a0 Merge pull request #622 from technoboy10/gh620-coming-soon
Fix GH-620: Replace "Request account" with "Coming Soon"
2016-06-29 10:41:28 -04:00
Technoboy10
ce4069fdb1 tweak padding 2016-06-29 09:56:15 -04:00
Technoboy10
db039739dd change request account button to coming soon 2016-06-29 09:51:23 -04:00
Connor Hudson
221170a9ff Merge pull request #616 from technoboy10/gh537-dropdown-gap
Fix GH-537: Logged-in user dropdown gap
2016-06-29 08:58:16 -04:00