Matthew Taylor
0111278fa5
Update id string for general error message strings
...
Fixes #1112 , which was created by moving the error message into `general`
2016-12-15 15:32:40 -05:00
Matthew Taylor
afa25dc1c2
Move other input to be the label for the button
...
thanks @rschamp! Never would’ve thought label would accept html.
2016-12-05 14:05:27 -05:00
The_Grits
21941ecf86
Phone Number 'Required' Validation
2016-11-04 11:51:48 -04:00
The_Grits
10e49d87b3
Empty Phone Number Validation
...
Separated the null check from the area code check so that when the field is null the 'required' popup will be displayed.
2016-10-26 14:15:54 -04:00
Matthew Taylor
99cedec978
Put label for “Not Required” above input
...
Fixes #933
2016-09-30 15:02:05 -04:00
Matthew Taylor
2e3aee25d9
cover undefined
case as well
...
thanks @rschamp!
2016-09-01 16:22:45 -04:00
Matthew Taylor
ffa249c3c5
Check for username before sending
...
the `//` for an empty username that gets sent to the backend causes a 500 error. This is an edge case in formsy, as it has not detected a change value yet, so handle it in the username validation method. Fixes #872
2016-09-01 14:59:02 -04:00
Matthew Taylor
e7b0415a6b
Only require zip code for US addresses
...
Since we only check for the US, only require for that country. Other countries have zip codes, but it seems better to do it this way than codify which countries do/do not have zip codes (in case local practices are not the same as international information). Fixes #825
2016-08-26 11:14:26 -04:00
Matthew Taylor
59d558116e
Merge pull request #836 from mewtaylor/issue/gh-760
...
Fix GH-760: Add username `not equals` to password validation
2016-08-15 13:29:46 -04:00
Matthew Taylor
e791c0a8ff
Merge branch 'issue/gh-835' of https://github.com/mewtaylor/scratch-www-1 into develop
...
* 'issue/gh-835' of https://github.com/mewtaylor/scratch-www-1 :
Switch ordering
Remove `option` warning in console
Add `maxLength` validations where needed
# Conflicts:
# src/components/registration/steps.jsx
2016-08-12 17:23:32 -04:00
Matthew Taylor
61ef3c2c69
Switch ordering
...
so `intl` comes first
2016-08-12 16:43:56 -04:00
Matthew Taylor
0d9493de12
Remove option
warning in console
...
`option` throws an error in React if it’s not a string. `FormattedMessage` returns a `span` around strings, so any time this function was loaded/called, it was throwing >100 warnings in the console. use `intl` to return a string instead.
2016-08-12 15:47:44 -04:00
Matthew Taylor
6d5bb4f850
Add maxLength
validations where needed
...
fixes #835
2016-08-12 15:39:39 -04:00
Matthew Taylor
f8de61f067
Update from feedback
...
use props for username rather than constructed form data, and `studentUsername -> username`. Thanks @rschamp!
2016-08-12 10:11:14 -04:00
Matthew Taylor
537104c56b
Add username validation to student complete registration
...
Fixes #760
2016-08-12 08:10:20 -04:00
Matthew Taylor
6e3a18a574
only look for empty phone on submit
...
thanks @rschamp!
2016-08-10 09:45:21 -04:00
Matthew Taylor
56e88685b5
Check for empty phone number on submit
...
Thanks @rschamp!
2016-08-10 09:38:43 -04:00
Matthew Taylor
56481c797e
Remove phoneLength
validation
...
It appears that some valid phone numbers in some countries differ in length from what is specified in the util’s phone number format. Fixes #816 .
2016-08-10 07:47:12 -04:00
Matthew Taylor
73fbc36ff9
declare callback if undefined
2016-08-03 16:24:51 -04:00
Matthew Taylor
86662e13d6
Consolidate and remove onValidSubmit
2016-08-03 15:20:58 -04:00
Matthew Taylor
4e568f7c06
use minLength instead
...
it’s the same thing :). Thanks @rschamp!
2016-08-03 14:34:07 -04:00
Matthew Taylor
cec3214def
some updates from feedback
...
thanks @rschamp!
1. moved org type validation to a custom validation
2. added a callback to the username validation call
2016-08-03 12:11:55 -04:00
Matthew Taylor
f0c2280fde
Updates to registration UX for teachers
...
1. Phone too long validation occurs before submit now.
2. Organization “other” type is now being required
3. Organization type required now shows up at the same time as other organization validation errors
4. Username check now occurs earlier, on blur rather than on submit
2016-08-02 15:23:09 -04:00
Ray Schamp
e218cc5169
Move "select country" to general strings
...
It's reused in the other registration views so doesn't belong in teacherregistration/l10n.json
Fixes #783
2016-07-28 12:26:56 -04:00
Matthew Taylor
40fb433d7d
Make country choice a function that’s called
...
And also default the country in address to the country in demographics. Thanks @rschamp @carljbowman!
2016-07-28 09:56:01 -04:00
Matthew Taylor
2650e6e148
Move countryOptions to the global scope
...
thanks @rschamp!
2016-07-28 08:30:29 -04:00
Matthew Taylor
cf4a057278
Fix “afterschool” typo
...
Also make default country selectable in the user demographic step, and fix the spacing with `Create a Username`
2016-07-27 23:33:45 -04:00
Ray Schamp
19d67dc0b4
Resurrect old invite step design for new users
2016-07-27 19:32:08 -04:00
Ray Schamp
89071b10d0
Lint
2016-07-27 14:12:55 -04:00
Ray Schamp
d1f73c3ef4
Redesign invite step, add option to log out
...
Resolves #752
2016-07-27 10:24:37 -04:00
Matthew Taylor
806fd25e46
Move to the view
...
thanks @rschamp!
2016-07-26 17:03:41 -04:00
Matthew Taylor
60a62bb374
Redirect to /educators/classes
if a confirmed teacher
...
Fixes #757 . Note: Because we are getting this info from the session, the redirect may not happen until the page is rendered first in cases where the connection is slow, or the db is slow.
2016-07-26 15:24:51 -04:00
Ray Schamp
7455807591
Provide RegistrationError content as children
...
This allows us to do more inline formatting, so we don't have any of that outside of `render`.
Thanks @mewtaylor
2016-07-22 09:38:37 -04:00
Ray Schamp
be41d004ad
Show password by default
2016-07-21 21:08:07 -04:00
Ray Schamp
3335207c54
Update copy for password step
2016-07-21 21:08:07 -04:00
Ray Schamp
a4dd1611d1
Add student registration update view
2016-07-21 21:08:06 -04:00
Ray Schamp
7a6e5c3eb4
Fix student registration localization
...
Add missing strings, actually translate the content of the steps
2016-07-21 21:08:06 -04:00
Ray Schamp
8dae646ff3
Style tweaks
2016-07-21 20:44:51 -04:00
Ray Schamp
b06a9e49d0
Fix wording on student username step
2016-07-21 20:44:51 -04:00
Ray Schamp
9aa7e828b7
Remove "blank" classroom, show spinner instead
...
It was broken due to a key error on `classroom.images` anyway
2016-07-21 20:44:51 -04:00
Ray Schamp
754859f35f
Update image format for API change
...
Removed default `image` field convention
2016-07-20 13:47:43 -04:00
Ray Schamp
a3b56dcbf1
Fix lint errors, l10n issues
2016-07-20 12:07:19 -04:00
Ray Schamp
6d5b7d3c02
Update description of demographics step
2016-07-19 22:58:50 -04:00
Ray Schamp
1c5940cc05
Add student registration flow
2016-07-19 16:51:28 -04:00
Ray Schamp
67ecb60f48
Make registration styles reusable
2016-07-19 16:49:12 -04:00
Matthew Taylor
075f1481a2
Add custom validation for organization and phone
...
It appears that the `required` field is not applied in the way we'd like it to be for the custom checkbox group and custom phone input fields, so do a `required` check on form submission. Additionally, this adds in a few style fixes. Fixes #695 , #694 , #693 , #691
2016-07-07 16:56:51 -04:00
Ray Schamp
d990dee755
Move location of the general error message
...
From review of the style with @carljbowman
Requires a bit of magic, where the Form component manually adds the "all" value. But without a major overhaul of the validation system, I don't see how else to put the general error among the other fields.
2016-07-05 12:06:10 -04:00
Ray Schamp
5b288e4d3e
Merge pull request #648 from rschamp/feature/username-clarity
...
Clarify username field is not for logging in
2016-06-30 16:17:14 -04:00
Ray Schamp
0816b0ec0f
Clarify username field is not for logging in
2016-06-30 16:16:31 -04:00
Ray Schamp
554e21cd15
Fix localization of address validation message
...
Fixes #608
2016-06-30 15:54:32 -04:00