Review feedback

This commit is contained in:
rschamp 2019-11-27 15:45:35 -05:00
parent d83769be71
commit fdddad3516
2 changed files with 13 additions and 18 deletions

View file

@ -38,9 +38,6 @@
"hocbanner.imagine": "Imagine a World", "hocbanner.imagine": "Imagine a World",
"hocbanner.codeACartoon": "Code a Cartoon", "hocbanner.codeACartoon": "Code a Cartoon",
"hocbanner.talking": "Talking Tales", "hocbanner.talking": "Talking Tales",
"hocbanner.name": "Animate a Name",
"hocbanner.fly": "Make it Fly",
"hocbanner.pong": "Pong Game",
"welcome.welcomeToScratch": "Welcome to Scratch!", "welcome.welcomeToScratch": "Welcome to Scratch!",
"welcome.learn": "Learn how to make a project in Scratch", "welcome.learn": "Learn how to make a project in Scratch",

View file

@ -419,22 +419,20 @@ class SplashPresentation extends React.Component { // eslint-disable-line react/
{ {
this.props.sessionStatus === sessionActions.Status.FETCHED && this.props.sessionStatus === sessionActions.Status.FETCHED &&
Object.keys(this.props.user).length === 0 && (// Only show top banner if user is not logged in Object.keys(this.props.user).length === 0 && (// Only show top banner if user is not logged in
/* eslint-disable indent, react/jsx-indent, react/jsx-indent-props */ (Date.now() >= HOC_START_TIME && Date.now() < HOC_END_TIME) ? (
(Date.now() >= HOC_START_TIME && Date.now() < HOC_END_TIME) ? ( <MediaQuery
<MediaQuery key="frameless-tablet"
key="frameless-tablet" minWidth={frameless.tabletPortrait}
minWidth={frameless.tabletPortrait} >
> <TopBanner />
<TopBanner /> </MediaQuery>
</MediaQuery> ) : (
) : ( <Intro
<Intro key="intro"
key="intro" messages={messages}
messages={messages} />
/> )
)
) )
/* eslint-enable indent, react/jsx-indent, react/jsx-indent-props */
} }
<div <div
className="inner mod-splash" className="inner mod-splash"