scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2025-02-17 08:31:23 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

moved NaN check in preview.jsx to be guard-style

Browse source
This commit is contained in:
Ben Wheeler 2018-07-31 16:38:49 -04:00
parent d5e1401968
commit e83f29dbbc
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/views/preview/preview.jsx
View file

@ -213,17 +213,16 @@ class Preview extends React.Component {
}
handleToggleStudio (event) {
const studioId = parseInt(event.currentTarget.dataset.id, 10);
if (!isNaN(studioId)) { // probably unnecessary test; should always be a number
const studio = this.props.studios.find(thisStudio => (thisStudio.id === studioId));
// only send add or leave request to server if we know current status
if ((typeof studio !== 'undefined') && ('includesProject' in studio)) {
this.props.toggleStudio(
(studio.includesProject === false),
studioId,
this.props.projectInfo.id,
this.props.user.token
);
}
if (isNaN(studioId)) { return; } // sanity check in case event had no integer data-id
const studio = this.props.studios.find(thisStudio => (thisStudio.id === studioId));
// only send add or leave request to server if we know current status
if ((typeof studio !== 'undefined') && ('includesProject' in studio)) {
this.props.toggleStudio(
(studio.includesProject === false),
studioId,
this.props.projectInfo.id,
this.props.user.token
);
}
}
handleFavoriteToggle () {