scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-23 07:38:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add shouldFallback process env variable

Browse source 
So that it's clear to newcomers what things are not yet completed in scratch-www as we build it out.
This commit is contained in:
Matthew Taylor 2015-12-03 10:41:02 -05:00
parent cf2a5cc477
commit d630efb23c
2 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -30,8 +30,12 @@ Use `^C` to stop the node process `npm start` starts.
| `API_HOST` | `https://api.scratch.mit.edu` | Hostname for API requests | | `API_HOST` | `https://api.scratch.mit.edu` | Hostname for API requests |
| `NODE_ENV` | `null` | If not `production`, app acts like development | | `NODE_ENV` | `null` | If not `production`, app acts like development |
| `PORT` | `8333` | Port for devserver (http://localhost:XXXX) | | `PORT` | `8333` | Port for devserver (http://localhost:XXXX) |
| `FALLBACK` | `false` | Whether or not to fallback to `PROXY_HOST` for non-existent pages/reqeusts |
| `PROXY_HOST` | `https://scratch.mit.edu` | Pass-through location for scratchr2 | | `PROXY_HOST` | `https://scratch.mit.edu` | Pass-through location for scratchr2 |
#### Current issues with the development
* Login does not work (*In the process of being fixed*)
### To Test ### To Test
```bash ```bash
npm test npm test

11
server/index.js
View file

@ -79,10 +79,13 @@ if (!isProduction) {
} }
})); }));
// Fall back to scratchr2 in development var shouldFallback = (process.env.FALLBACK === 'true') || false;
// This proxy middleware must come last if (shouldFallback) {
var proxyHost = process.env.PROXY_HOST || 'https://scratch.mit.edu'; // Fall back to scratchr2 in development
app.use('/', proxy(proxyHost)); // This proxy middleware must come last
var proxyHost = process.env.PROXY_HOST || 'https://scratch.mit.edu';
app.use('/', proxy(proxyHost));
}
} }
// Start listening // Start listening