scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-27 09:35:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

renamed lookupCountryInfo and lookupCountryName functions

Browse source
This commit is contained in:
Ben Wheeler 2020-06-19 10:42:34 -04:00
parent 665eeff75a
commit d388eef59f
3 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/registration/steps.jsx
View file

@ -456,7 +456,7 @@ class DemographicsStep extends React.Component {
// look up country name using user's country code selection ('us' -> 'United States')
getCountryName (values) {
if (values.countryCode) {
const countryInfo = countryData.lookupCountryInfo(values.countryCode);
const countryInfo = countryData.lookupCountryByCode(values.countryCode);
if (countryInfo) {
return countryInfo.name;
}
@ -466,7 +466,7 @@ class DemographicsStep extends React.Component {
// look up country code from country label ('United States' -> 'us')
// if `countryName` is not found, including if it's null or undefined, then this function will return undefined.
getCountryCode (countryName) {
const country = countryData.lookupCountryName(countryName);
const country = countryData.lookupCountryByName(countryName);
return country && country.code;
}
handleValidSubmit (formData) {

4
src/lib/country-data.js
View file

@ -1036,11 +1036,11 @@ const countryOptions = module.exports.countryOptions = (startingCountryInfo, val
))
);
module.exports.lookupCountryInfo = countryCode => (
module.exports.lookupCountryByCode = countryCode => (
countryInfo.find(country => country.code === countryCode)
);
module.exports.lookupCountryName = countryName => (
module.exports.lookupCountryByName = countryName => (
countryInfo.find(country => country.name === countryName)
);

17
test/unit/lib/country-data.test.js
View file

@ -1,7 +1,8 @@
const {
countryInfo,
countryOptions,
lookupCountryInfo,
lookupCountryByCode,
lookupCountryByName,
dupeCommonCountries,
registrationCountryCodeOptions,
registrationCountryNameOptions,
@ -45,9 +46,17 @@ describe('unit test lib/country-data.js', () => {
expect(szInfo.label).toEqual('Eswatini');
});
test('lookupCountryInfo() will find country info', () => {
expect(typeof lookupCountryInfo).toBe('function');
const eswatiniInfo = lookupCountryInfo('sz');
test('lookupCountryByCode() will find country info', () => {
expect(typeof lookupCountryByCode).toBe('function');
const eswatiniInfo = lookupCountryByCode('sz');
expect(eswatiniInfo.name).toEqual('Swaziland');
expect(eswatiniInfo.display).toEqual('Eswatini');
expect(eswatiniInfo.code).toEqual('sz');
});
test('lookupCountryByName() will find country info', () => {
expect(typeof lookupCountryByName).toBe('function');
const eswatiniInfo = lookupCountryByName('Swaziland');
expect(eswatiniInfo.name).toEqual('Swaziland');
expect(eswatiniInfo.display).toEqual('Eswatini');
expect(eswatiniInfo.code).toEqual('sz');