scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2025-02-17 00:21:20 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix click not working on highlighted comment avatar

Browse source 
The absolutely positioned :before highlight was eating clicks from the relatively positioned elements after it, like the avatar image. Disable pointer events to prevent this background element from receiving clicks.

This is due to a subtle issue with element ordering, even elements that are before other elements get automatically promoted above siblings that are relatively positioned. That is why the reply/delete buttons still work on highlighted comments (they are also absolutely positioned) but the avatar user link did not work.
This commit is contained in:
Paul Kaplan 2019-08-08 16:01:41 -04:00 committed by GitHub
parent 3269565079
commit c2c165d6f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/views/preview/comment/comment.scss
View file

@ -83,6 +83,13 @@
width: calc(100% + 1rem);
height: 100%;
content: "";
/*
Because this :before is absolutely positioned, it will eat clicks
from non-absolute elements after it (like the author link).
Prevent this by explicitly disabling pointer events on this background element.
*/
pointer-events: none;
}
.comment-top-row {