From 6d8441dd0322909df28b64931f601eb508a40d10 Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Sat, 25 May 2019 09:37:54 -0400 Subject: [PATCH 1/5] fix firefox instructions height overflow issue --- src/views/preview/preview.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/views/preview/preview.scss b/src/views/preview/preview.scss index a8e666ddd..f8762ac6b 100644 --- a/src/views/preview/preview.scss +++ b/src/views/preview/preview.scss @@ -444,6 +444,12 @@ $stage-width: 480px; height: 100%; flex-direction: column; align-items: flex-start; + /* + necessary to fix flexbox sizing issue that caused instructions + to flow over the top and bottom of the project notes section. + see https://stackoverflow.com/a/36247448 + */ + min-height: 0; } .project-textlabel { From 4f7791032c786069029c35eba14bdb75bbaeb096 Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Sat, 25 May 2019 10:08:39 -0400 Subject: [PATCH 2/5] set min-height of remix credit to max-content --- src/views/preview/preview.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/views/preview/preview.scss b/src/views/preview/preview.scss index a8e666ddd..2a4534bdf 100644 --- a/src/views/preview/preview.scss +++ b/src/views/preview/preview.scss @@ -425,6 +425,11 @@ $stage-width: 480px; flex-wrap: nowrap; align-items: center; justify-content: flex-start; + /* + Necessary to force Mac Safari to apply padding to the height of the + child elements. See https://stackoverflow.com/a/52273082/2308190 + */ + min-height: max-content; @media #{$medium-and-smaller} { flex-direction: row; From e788d2d77b85848f9634614a7f5ef492f13667bf Mon Sep 17 00:00:00 2001 From: Colby Gutierrez-Kraybill Date: Wed, 29 May 2019 16:50:55 -0400 Subject: [PATCH 3/5] Update scratch-gui --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index cfeeae5aa..7222bb267 100644 --- a/package.json +++ b/package.json @@ -101,7 +101,7 @@ "react-responsive": "3.0.0", "react-slick": "0.16.0", "react-string-replace": "0.4.1", - "scratch-gui": "0.1.0-prerelease.20190522232752", + "scratch-gui": "0.1.0-prerelease.20190529191233", "react-telephone-input": "4.3.4", "redux": "3.5.2", "redux-thunk": "2.0.1", From b2a22c6a11b3281fd8f178ca0d3492d86462a1e5 Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Thu, 30 May 2019 13:02:20 -0400 Subject: [PATCH 4/5] update gui version with 4 reversions --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7222bb267..838bd7f73 100644 --- a/package.json +++ b/package.json @@ -101,7 +101,7 @@ "react-responsive": "3.0.0", "react-slick": "0.16.0", "react-string-replace": "0.4.1", - "scratch-gui": "0.1.0-prerelease.20190529191233", + "scratch-gui": "0.1.0-prerelease.20190530164635", "react-telephone-input": "4.3.4", "redux": "3.5.2", "redux-thunk": "2.0.1", From d32dc86508be1b321cfbe483aa90c3999a4bc1f8 Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Thu, 30 May 2019 14:24:56 -0400 Subject: [PATCH 5/5] updated to correct scratch-gui release --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 838bd7f73..832f73b31 100644 --- a/package.json +++ b/package.json @@ -101,7 +101,7 @@ "react-responsive": "3.0.0", "react-slick": "0.16.0", "react-string-replace": "0.4.1", - "scratch-gui": "0.1.0-prerelease.20190530164635", + "scratch-gui": "0.1.0-prerelease.20190530174801", "react-telephone-input": "4.3.4", "redux": "3.5.2", "redux-thunk": "2.0.1",