Merge pull request #2969 from benjiwheeler/make-translations

fix "make translations" command
This commit is contained in:
Benjamin Wheeler 2019-05-13 17:08:23 -04:00 committed by GitHub
commit b2d5bbcb93
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -106,7 +106,9 @@ for ( var l in languages ) {
l + '.json' l + '.json'
); );
fs.accessSync(langTranslations); fs.accessSync(langTranslations);
generalLocales[l] = JSON.parse(fs.readFileSync(langTranslations, 'utf8')); if (l !== 'en') {
generalLocales[l] = JSON.parse(fs.readFileSync(langTranslations, 'utf8'));
}
} catch (err) { } catch (err) {
// just use english // just use english
generalLocales[l] = generalLocales['en']; generalLocales[l] = generalLocales['en'];
@ -128,7 +130,7 @@ var localizedAssetUrls = {};
// - the route name // - the route name
// - the transifex resource // - the transifex resource
// Add exceptions: // Add exceptions:
// - txMapping: if the name of the transifex resource is different from the route name // - txMapping: if the name of the transifex resource is different from the route name
var txMapping = { var txMapping = {
'projects': 'preview', 'projects': 'preview',
'scratch_1.4': 'scratch_14' // transifex doesn't allow dots in resource names 'scratch_1.4': 'scratch_14' // transifex doesn't allow dots in resource names
@ -228,8 +230,11 @@ async.forEachLimit(views, 5, function (view, cb) {
} }
} }
try { try {
viewLocales[isoCode] = merge({}, generalLocales[isoCode], JSON.parse(data)); // don't overwrite english view strings
defaults(viewLocales[isoCode], viewLocales['en']); if (isoCode !== 'en') {
viewLocales[isoCode] = merge({}, generalLocales[isoCode], JSON.parse(data));
defaults(viewLocales[isoCode], viewLocales['en']);
}
} catch (e) { } catch (e) {
return cb(e); return cb(e);
} }