scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-27 17:45:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Comment the useEffect usage

Browse source
This commit is contained in:
Paul Kaplan 2021-03-18 11:38:38 -04:00
parent f40f3fa7c7
commit 96589f4066
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/views/studio/studio-activity.jsx
View file

@ -10,9 +10,12 @@ import Debug from './debug.jsx';
const StudioActivity = ({items, loading, error, onInitialLoad}) => { const StudioActivity = ({items, loading, error, onInitialLoad}) => {
const {studioId} = useParams(); const {studioId} = useParams();
// Fetch the data if none has been loaded yet. This would run only once,
// since studioId doesnt change, but the component is potentially mounted
// multiple times because of tab routing, so need to check for empty items.
useEffect(() => { useEffect(() => {
if (studioId && items.length === 0) onInitialLoad(studioId); if (studioId && items.length === 0) onInitialLoad(studioId);
}, [studioId]); }, [studioId]); // items.length intentionally left out
return ( return (
<div> <div>