scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2025-02-17 00:21:20 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix base modal prop passed to ReactModal (#2165)

Browse source
This commit is contained in:
Benjamin Wheeler 2018-10-10 14:08:59 -04:00 committed by GitHub
parent 69299d3ef9
commit 8b222f0466
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/components/modal/base/modal.jsx
View file

@ -26,7 +26,11 @@ class Modal extends React.Component {
return (
<ReactModal
appElement={document.getElementById('app')}
bodyOpenClassName={this.props.useStandardSizes ? classNames('overflow-hidden') : null}
// bodyOpenClassName can be blank string, but must not be null here; a null value causes
// an error, because ReactModal does not correctly handle the case of a null bodyOpenClassName
bodyOpenClassName={classNames({
'overflow-hidden': this.props.useStandardSizes
})}
className={{
base: classNames('modal-content', this.props.className, {
'modal-sizes': this.props.useStandardSizes