scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-22 15:17:53 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

revise join flow tests to use refreshSessionWithRetry

Browse source
This commit is contained in:
Ben Wheeler 2019-12-05 23:27:13 -05:00
parent 5aa27c31d1
commit 8635f3b152
1 changed files with 28 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
test/unit/components/join-flow.test.jsx
View file

@ -41,7 +41,7 @@ describe('JoinFlow', () => {
beforeEach(() => {
store = mockStore({sessionActions: {
refreshSession: jest.fn()
refreshSessionWithRetry: jest.fn()
}});
});
@ -283,16 +283,31 @@ describe('JoinFlow', () => {
expect(success).toEqual(false);
});
test('handleRegistrationResponse when passed body with success', () => {
test('handleRegistrationResponse calls refreshSessionWithRetry() when passed body with success', done => {
const props = {
refreshSession: jest.fn()
refreshSessionWithRetry: () => (new Promise(() => { // eslint-disable-line no-undef
done(); // ensures that joinFlowInstance.props.refreshSessionWithRetry() was called
}))
};
const joinFlowInstance = getJoinFlowWrapper(props).instance();
joinFlowInstance.handleRegistrationResponse(null, responseBodySuccess, {statusCode: 200});
expect(joinFlowInstance.state.registrationError).toEqual(null);
expect(joinFlowInstance.props.refreshSession).toHaveBeenCalled();
expect(joinFlowInstance.state.step).toEqual(1);
expect(joinFlowInstance.state.waiting).toBeFalsy();
});
test('handleRegistrationResponse advances to next step when passed body with success', () => {
const props = {
refreshSessionWithRetry: () => (new Promise(resolve => { // eslint-disable-line no-undef
resolve();
}))
};
const joinFlowInstance = getJoinFlowWrapper(props).instance();
joinFlowInstance.handleRegistrationResponse(null, responseBodySuccess, {statusCode: 200});
process.nextTick(
() => {
expect(joinFlowInstance.state.registrationError).toEqual(null);
expect(joinFlowInstance.state.step).toEqual(1);
expect(joinFlowInstance.state.waiting).toBeFalsy();
}
);
});
test('handleRegistrationResponse when passed body with preset server error', () => {
@ -306,7 +321,7 @@ describe('JoinFlow', () => {
test('handleRegistrationResponse with failure response, with error fields missing', () => {
const props = {
refreshSession: jest.fn()
refreshSessionWithRetry: jest.fn()
};
const joinFlowInstance = getJoinFlowWrapper(props).instance();
const responseErr = null;
@ -320,7 +335,7 @@ describe('JoinFlow', () => {
statusCode: 200
};
joinFlowInstance.handleRegistrationResponse(responseErr, responseBody, responseObj);
expect(joinFlowInstance.props.refreshSession).not.toHaveBeenCalled();
expect(joinFlowInstance.props.refreshSessionWithRetry).not.toHaveBeenCalled();
expect(joinFlowInstance.state.registrationError).toEqual({
errorAllowsTryAgain: false,
errorMsg: null
@ -339,7 +354,7 @@ describe('JoinFlow', () => {
test('handleRegistrationResponse with failure response, with no text explanation', () => {
const props = {
refreshSession: jest.fn()
refreshSessionWithRetry: jest.fn()
};
const joinFlowInstance = getJoinFlowWrapper(props).instance();
const responseErr = null;
@ -352,7 +367,7 @@ describe('JoinFlow', () => {
statusCode: 200
};
joinFlowInstance.handleRegistrationResponse(responseErr, responseBody, responseObj);
expect(joinFlowInstance.props.refreshSession).not.toHaveBeenCalled();
expect(joinFlowInstance.props.refreshSessionWithRetry).not.toHaveBeenCalled();
expect(joinFlowInstance.state.registrationError).toEqual({
errorAllowsTryAgain: false,
errorMsg: null
@ -369,11 +384,11 @@ describe('JoinFlow', () => {
test('handleRegistrationResponse when passed status 400', () => {
const props = {
refreshSession: jest.fn()
refreshSessionWithRetry: jest.fn()
};
const joinFlowInstance = getJoinFlowWrapper(props).instance();
joinFlowInstance.handleRegistrationResponse({}, responseBodyMultipleErrs, {statusCode: 400});
expect(joinFlowInstance.props.refreshSession).not.toHaveBeenCalled();
expect(joinFlowInstance.props.refreshSessionWithRetry).not.toHaveBeenCalled();
expect(joinFlowInstance.state.registrationError).toEqual({
errorAllowsTryAgain: true
});