mirror of
https://github.com/scratchfoundation/scratch-www.git
synced 2025-02-17 00:21:20 -05:00
Merge pull request #7308 from bocoup/landmark-elements-7170-v2
CE-272: Implement semantic landmark elements to improve Screen Reader navigation
This commit is contained in:
commit
76d24dc04a
4 changed files with 20 additions and 22 deletions
|
@ -235,7 +235,7 @@ class JoinFlow extends React.Component {
|
|||
|
||||
render () {
|
||||
return (
|
||||
<React.Fragment>
|
||||
<main>
|
||||
{this.state.registrationError ? (
|
||||
<RegistrationErrorStep
|
||||
canTryAgain={this.canTryAgain()}
|
||||
|
@ -280,7 +280,7 @@ class JoinFlow extends React.Component {
|
|||
/>
|
||||
</Progression>
|
||||
)}
|
||||
</React.Fragment>
|
||||
</main>
|
||||
);
|
||||
}
|
||||
}
|
||||
|
|
|
@ -17,24 +17,24 @@ const Page = ({
|
|||
}) => (
|
||||
<ErrorBoundary componentName="Page">
|
||||
<div className={classNames('page', className)}>
|
||||
<div
|
||||
<nav
|
||||
className={classNames({
|
||||
staging: process.env.SCRATCH_ENV === 'staging'
|
||||
})}
|
||||
id="navigation"
|
||||
>
|
||||
<Navigation />
|
||||
</div>
|
||||
<div id="view">
|
||||
</nav>
|
||||
<main id="view">
|
||||
{children}
|
||||
</div>
|
||||
<div id="footer">
|
||||
</main>
|
||||
<footer id="footer">
|
||||
<Footer />
|
||||
</div>
|
||||
</footer>
|
||||
{showDonorRecognition &&
|
||||
<div id="donor">
|
||||
<aside id="donor">
|
||||
<DonorRecognition />
|
||||
</div>
|
||||
</aside>
|
||||
}
|
||||
</div>
|
||||
{semi && <div style={{color: '#fff'}}>{';'}</div>}
|
||||
|
|
|
@ -14,16 +14,14 @@ const Registration = ({
|
|||
isOpen,
|
||||
showCloseButton
|
||||
}) => (
|
||||
<div>
|
||||
<JoinModal
|
||||
createProjectOnComplete={createProjectOnComplete}
|
||||
isOpen={isOpen}
|
||||
key="join-modal"
|
||||
showCloseButton={showCloseButton}
|
||||
onCompleteRegistration={handleCompleteRegistration}
|
||||
onRequestClose={handleCloseRegistration}
|
||||
/>
|
||||
</div>
|
||||
<JoinModal
|
||||
createProjectOnComplete={createProjectOnComplete}
|
||||
isOpen={isOpen}
|
||||
key="join-modal"
|
||||
showCloseButton={showCloseButton}
|
||||
onCompleteRegistration={handleCompleteRegistration}
|
||||
onRequestClose={handleCloseRegistration}
|
||||
/>
|
||||
);
|
||||
|
||||
Registration.propTypes = {
|
||||
|
|
|
@ -9,7 +9,7 @@ initSentry();
|
|||
require('./join.scss');
|
||||
const Register = () => (
|
||||
<ErrorBoundary componentName="Join">
|
||||
<div className="join">
|
||||
<nav className="join">
|
||||
<a
|
||||
aria-label="Scratch"
|
||||
href="/"
|
||||
|
@ -20,7 +20,7 @@ const Register = () => (
|
|||
/>
|
||||
</a>
|
||||
|
||||
</div>
|
||||
</nav>
|
||||
<Scratch3Registration
|
||||
createProjectOnComplete
|
||||
isOpen
|
||||
|
|
Loading…
Reference in a new issue