scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-30 10:58:23 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Use empty default object

Browse source 
Looks as if the having one of these objects as the default causes overwriting in some way, as opposed to augmentation. Have the source object be an empty one, so that it gets the attributes of both defaults and props. Fixes #642.
This commit is contained in:
Matthew Taylor 2016-06-30 16:52:46 -04:00
parent 5b288e4d3e
commit 6db426a586
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/components/forms/validations.jsx
View file

@ -29,8 +29,9 @@ module.exports.validationHOCFactory = function (defaultValidationErrors) {
var ValidatedComponent = React.createClass({ var ValidatedComponent = React.createClass({
render: function () { render: function () {
var validationErrors = defaults( var validationErrors = defaults(
this.props.validationErrors, {},
defaultValidationErrors defaultValidationErrors,
this.props.validationErrors
); );
return ( return (
<Component {...this.props} validationErrors={validationErrors} /> <Component {...this.props} validationErrors={validationErrors} />