From 220b027c46eb08c2391084cb55af63d1e97312df Mon Sep 17 00:00:00 2001 From: apple502j <33279053+apple502j@users.noreply.github.com> Date: Fri, 4 Jan 2019 10:28:06 +0900 Subject: [PATCH 1/3] capitalize URL --- src/l10n.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/l10n.json b/src/l10n.json index 63fcd1011..f8d8f3285 100644 --- a/src/l10n.json +++ b/src/l10n.json @@ -88,7 +88,7 @@ "general.copyLink": "Copy Link", "general.report": "Report", "general.notAvailableHeadline": "Whoops! Our server is Scratch'ing its head", - "general.notAvailableSubtitle": "We couldn't find the page you're looking for. Check to make sure you've typed the url correctly.", + "general.notAvailableSubtitle": "We couldn't find the page you're looking for. Check to make sure you've typed the URL correctly.", "general.seeAllComments": "See all comments", "general.all": "All", From 1d223825dfc5a11279507e3388278d8022f58a4e Mon Sep 17 00:00:00 2001 From: chrisgarrity Date: Mon, 7 Jan 2019 10:33:20 -0500 Subject: [PATCH 2/3] Disallow comments on an unshared project --- src/views/preview/presentation.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/views/preview/presentation.jsx b/src/views/preview/presentation.jsx index 4e8f2a29c..9aa492973 100644 --- a/src/views/preview/presentation.jsx +++ b/src/views/preview/presentation.jsx @@ -522,7 +522,7 @@ const PreviewPresentation = ({ {projectInfo.comments_allowed ? ( isLoggedIn ? ( - @@ -543,7 +543,7 @@ const PreviewPresentation = ({ Date: Mon, 7 Jan 2019 11:09:44 -0500 Subject: [PATCH 3/3] restore 5000 character limit for description fields Also make sure that validation error message is visible when 5000 character limit is exceeded. --- src/views/preview/presentation.jsx | 6 ++---- src/views/preview/preview.scss | 3 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/views/preview/presentation.jsx b/src/views/preview/presentation.jsx index 4e8f2a29c..ced3f35de 100644 --- a/src/views/preview/presentation.jsx +++ b/src/views/preview/presentation.jsx @@ -379,8 +379,7 @@ const PreviewPresentation = ({ }) }} validations={{ - // TODO: actual 5000 - maxLength: 1000 + maxLength: 5000 }} value={projectInfo.instructions} /> @@ -423,8 +422,7 @@ const PreviewPresentation = ({ }) }} validations={{ - // TODO: actual 5000 - maxLength: 1000 + maxLength: 5000 }} value={projectInfo.description} /> diff --git a/src/views/preview/preview.scss b/src/views/preview/preview.scss index 075539ded..9a6fce550 100644 --- a/src/views/preview/preview.scss +++ b/src/views/preview/preview.scss @@ -470,7 +470,8 @@ $stage-width: 480px; &.has-error { .validation-message { - transform: translate(26rem, 0); + top: 100%; + right: 0; } }