scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-26 17:16:11 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Take user to the homepage when finishing the join flow (unless they came from the editor). There is replication lag that makes creating a project immediatley a bad experience. We'll fix this in a followup.

Browse source
This commit is contained in:
picklesrus 2019-11-15 11:00:44 -05:00
parent 0bc3df1bd2
commit 378cebe5f4
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/components/join-flow/welcome-step.jsx
View file

@ -50,7 +50,7 @@ class WelcomeStep extends React.Component {
innerClassName="join-flow-inner-welcome-step"
nextButton={this.props.createProjectOnComplete ? (
<React.Fragment>
<FormattedMessage id="registration.makeProject" />
<FormattedMessage id="general.getStarted" />
<img
className="join-flow-next-button-arrow"
src="/svgs/project/r-arrow.svg"

5
src/redux/navigation.js
View file

@ -105,7 +105,10 @@ module.exports.handleRegistrationRequested = () => ({
module.exports.handleCompleteRegistration = createProject => (dispatch => {
if (createProject) {
window.location = '/projects/editor/?tutorial=getStarted';
// TODO: Ideally this would take you to the editor with the getting started
// tutorial open. We need to do some extra work to wait for the user
// to be logged in before we try creating a project due to replication lag.
window.location = '/';
} else {
dispatch(sessionActions.refreshSession());
dispatch(module.exports.setRegistrationOpen(false));