Merge pull request #2431 from paulkaplan/fix-multi-love

Only try to update fave counts if there are no requests in progress.
This commit is contained in:
Paul Kaplan 2018-12-10 10:56:34 -05:00 committed by GitHub
commit 26e821214a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -391,6 +391,8 @@ class Preview extends React.Component {
}
}
handleFavoriteToggle () {
if (!this.props.favedLoaded) return;
this.props.setFavedStatus(
!this.props.faved,
this.props.projectInfo.id,
@ -412,6 +414,8 @@ class Preview extends React.Component {
this.props.isAdmin, this.props.user && this.props.user.token);
}
handleLoveToggle () {
if (!this.props.lovedLoaded) return;
this.props.setLovedStatus(
!this.props.loved,
this.props.projectInfo.id,
@ -681,6 +685,7 @@ Preview.propTypes = {
comments: PropTypes.arrayOf(PropTypes.object),
enableCommunity: PropTypes.bool,
faved: PropTypes.bool,
favedLoaded: PropTypes.bool,
fullScreen: PropTypes.bool,
getCommentById: PropTypes.func.isRequired,
getCuratedStudios: PropTypes.func.isRequired,
@ -710,6 +715,7 @@ Preview.propTypes = {
isShared: PropTypes.bool,
logProjectView: PropTypes.func,
loved: PropTypes.bool,
lovedLoaded: PropTypes.bool,
moreCommentsToLoad: PropTypes.bool,
original: projectShape,
parent: projectShape,
@ -797,6 +803,7 @@ const mapStateToProps = state => {
comments: state.preview.comments,
enableCommunity: projectInfoPresent,
faved: state.preview.faved,
favedLoaded: state.preview.status.faved === previewActions.Status.FETCHED,
fullScreen: state.scratchGui.mode.isFullScreen,
// project is editable iff logged in user is the author of the project, or
// logged in user is an admin.
@ -809,6 +816,7 @@ const mapStateToProps = state => {
isScratcher: isLoggedIn && state.permissions.scratcher,
isShared: isShared,
loved: state.preview.loved,
lovedLoaded: state.preview.status.loved === previewActions.Status.FETCHED,
moreCommentsToLoad: state.preview.moreCommentsToLoad,
original: state.preview.original,
parent: state.preview.parent,