scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-23 07:38:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #8900 from MiroslavDionisiev/feat/move-project-ids

Browse source 
refactor: move project ids list as env variable
This commit is contained in:
Miroslav Dionisiev 2024-11-08 14:21:45 +02:00 committed by GitHub
commit 0c02fa9984
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.github/workflows/ci-cd.yml vendored
View file

@ -69,6 +69,7 @@ jobs:
STATIC_HOST: ${{ secrets.STATIC_HOST }} STATIC_HOST: ${{ secrets.STATIC_HOST }}
SCRATCH_ENV: ${{ vars.SCRATCH_ENV }} SCRATCH_ENV: ${{ vars.SCRATCH_ENV }}
ONBOARDING_TEST_ACTIVE: ${{ secrets.ONBOARDING_TEST_ACTIVE }} ONBOARDING_TEST_ACTIVE: ${{ secrets.ONBOARDING_TEST_ACTIVE }}
ONBOARDING_TEST_PROJECT_IDS: ${{ secrets.ONBOARDING_TEST_PROJECT_IDS }}
ONBOARDING_TESTING_STARTING_DATE: ${{ secrets.ONBOARDING_TESTING_STARTING_DATE }} ONBOARDING_TESTING_STARTING_DATE: ${{ secrets.ONBOARDING_TESTING_STARTING_DATE }}
ONBOARDING_TESTING_ENDING_DATE: ${{ secrets.ONBOARDING_TESTING_ENDING_DATE }} ONBOARDING_TESTING_ENDING_DATE: ${{ secrets.ONBOARDING_TESTING_ENDING_DATE }}

9
src/components/journeys/editor-journey/editor-journey.jsx
View file

@ -106,14 +106,7 @@ const STEP_NAMES = [
'make-music-step' 'make-music-step'
]; ];
const projectIds = { const projectIds = JSON.parse(process.env.ONBOARDING_TEST_PROJECT_IDS);
clicker: '10128368',
pong: '10128515',
animateCharacter: '10128067',
makeItFly: '114019829',
recordSound: '1031325137',
makeMusic: '10012676'
};
const tutorialIds = { const tutorialIds = {
clicker: 'Make-A-Game', clicker: 'Make-A-Game',

10
webpack.config.js
View file

@ -288,6 +288,16 @@ module.exports = {
'process.env.ONBOARDING_TEST_ACTIVE': `"${ 'process.env.ONBOARDING_TEST_ACTIVE': `"${
process.env.ONBOARDING_TEST_ACTIVE || true process.env.ONBOARDING_TEST_ACTIVE || true
}"`, }"`,
'process.env.ONBOARDING_TEST_PROJECT_IDS': `'${process.env.ONBOARDING_TEST_PROJECT_IDS || JSON.stringify(
{
clicker: '10128368',
pong: '10128515',
animateCharacter: '10128067',
makeItFly: '114019829',
recordSound: '1031325137',
makeMusic: '10012676'
}
)}'`,
'process.env.ONBOARDING_TESTING_STARTING_DATE': `"${ 'process.env.ONBOARDING_TESTING_STARTING_DATE': `"${
process.env.ONBOARDING_TESTING_STARTING_DATE || '2024-01-20' process.env.ONBOARDING_TESTING_STARTING_DATE || '2024-01-20'
}"`, }"`,