scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-30 02:56:20 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

added simple memoizing cache for email step

Browse source
This commit is contained in:
Ben Wheeler 2019-09-27 12:26:25 -04:00
parent 3bc6e7ff6f
commit 0656ab6a9e
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/components/join-flow/email-step.jsx
View file

@ -21,6 +21,7 @@ class EmailStep extends React.Component {
'handleSetEmailRef',
'handleValidSubmit',
'validateEmail',
'validateEmailRemotelyWithCache',
'validateForm',
'setCaptchaRef',
'captchaSolved',
@ -30,8 +31,10 @@ class EmailStep extends React.Component {
this.state = {
captchaIsLoading: true
};
// simple object to memoize remote requests for email addresses.
// keeps us from submitting multiple requests for same data.
this.emailRemoteCache = {};
}
componentDidMount () {
// automatically start with focus on username field
if (this.emailInput) this.emailInput.focus();
@ -78,11 +81,24 @@ class EmailStep extends React.Component {
},
true);
}
// simple function to memoize remote requests for usernames
validateEmailRemotelyWithCache (email) {
if (this.emailRemoteCache.hasOwnProperty(email)) {
return Promise.resolve(this.emailRemoteCache[email]);
}
// email is not in our cache
return validate.validateEmailRemotely(email).then(
remoteResult => {
this.emailRemoteCache[email] = remoteResult;
return remoteResult;
}
);
}
validateEmail (email) {
if (!email) return this.props.intl.formatMessage({id: 'general.required'});
const localResult = validate.validateEmailLocally(email);
if (!localResult.valid) return this.props.intl.formatMessage({id: localResult.errMsgId});
return validate.validateEmailRemotely(email).then(
return this.validateEmailRemotelyWithCache(email).then(
remoteResult => {
if (remoteResult.valid === true) {
return null;