scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2024-11-27 01:25:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Avoid displaying an error when /news returns a 500

Browse source 
This situation probably occurs most frequently when running dev servers while offline, but could also happen if the API is having issues. 500 responses from the API should not take down the homepage so drastically, and are also sometimes unavoidable while working offline.
This commit is contained in:
Ray Schamp 2018-11-05 21:00:12 +00:00
parent 6d8235c7e8
commit 037078d623
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/views/splash/splash.jsx
View file

@ -71,7 +71,10 @@ class Splash extends React.Component {
getNews () { getNews () {
api({ api({
uri: '/news?limit=3' uri: '/news?limit=3'
}, (err, body) => { }, (err, body, resp) => {
if (resp.statusCode !== 200) {
return log.error(`Unexpected status code ${resp.statusCode} received from news request`);
}
if (!body) return log.error('No response body'); if (!body) return log.error('No response body');
if (!err) return this.setState({news: body}); if (!err) return this.setState({news: body});
}); });