Resolve feedback from review.

This commit is contained in:
Andrew Sliwinski 2015-09-08 07:54:15 -07:00
parent 2835d6d34f
commit 02d38c513a
7 changed files with 23 additions and 16 deletions

View file

@ -3,13 +3,13 @@
"pattern": "/",
"view": "splash"
},
{
"pattern": "/styleguide",
"view": "styleguide"
},
{
"pattern": "/about",
"view": "about",
"title": "About"
},
{
"pattern": "/components",
"view": "components"
}
]

View file

@ -10,8 +10,8 @@ module.exports = React.createClass({
},
render: function () {
return (
<div className="box">
<div className="header">
<div className={"box " + this.props.className}>
<div className="box-header">
<h4>{this.props.title}</h4>
<p>
<a href={this.props.moreUrl}>
@ -20,7 +20,7 @@ module.exports = React.createClass({
</p>
</div>
<div className="content">
<div className="box-content">
{this.props.children}
</div>
</div>

View file

@ -6,7 +6,7 @@
border-radius: 10px 10px 0 0;
box-shadow: 0 2px 3px rgba(34, 25, 25, 0.3);
.header {
.box-header {
display: block;
margin: 0;
height: 20px;
@ -36,7 +36,7 @@
}
}
.content {
.box-content {
display: block;
padding: 8px 20px;
clear: both;

View file

@ -15,8 +15,13 @@ module.exports = React.createClass({
},
render: function () {
return (
<Box title="Scratch News" more="View All" moreUrl="/news">
<ul className="news">
<Box
className="news"
title="Scratch News"
more="View All"
moreUrl="/news">
<ul>
{this.props.items.map(function (item) {
return (
<li key={item.id}>

View file

@ -1,9 +1,11 @@
.news {
display: block;
margin: 0;
padding: 0;
ul {
display: block;
margin: 0;
padding: 0;
list-style: none;
list-style: none;
}
li {
display: block;

View file

@ -2,7 +2,7 @@ var React = require('react');
var Box = require('../../components/box/box.jsx');
require('./styleguide.scss');
require('./components.scss');
var View = React.createClass({
render: function () {