scratchfoundation/scratch-www
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-www.git synced 2025-02-17 00:21:20 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

remove reloads from comment integration tests

Browse source
This commit is contained in:
BryceLTaylor 2021-12-02 16:26:23 -05:00
parent 47841d7891
commit 02af240a7e
2 changed files with 2 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
test/integration/comments.test.js
View file

@ -81,10 +81,6 @@ describe('comment tests', async () => {
await findByXpath(`//textarea[contains(text(), "${projectComment}")]`);
await clickXpath('//button[@class="button compose-post"]');
// reload the page
await driver.sleep(5000);
await driver.get(projectUrl);
// find the comment
let commentXpath = await `//div[@class="comment-bubble"]/span/span[contains(text(),` +
` "${projectComment}")]`;
@ -102,9 +98,6 @@ describe('comment tests', async () => {
await commentArea.sendKeys(profileComment);
await clickXpath('//div[@class="button small"]/a[contains(text(), "Post")]');
// reload page
await driver.get(profileUrl);
// find the comment
let newComment = await findByXpath(`//div[@class="comment "]/div/div[contains(text(),` +
` "${profileComment}")]`);
@ -124,10 +117,6 @@ describe('comment tests', async () => {
await findByXpath(`//textarea[contains(text(), "${studioComment}")]`);
await clickXpath('//button[@class="button compose-post"]');
// reload the page
await driver.sleep(5000);
await driver.get(studioUrl);
// find the comment
let commentXpath = `//div[@class="comment-bubble"]/span/span[contains(text(), "${studioComment}")]`;
let postedComment = await findByXpath(commentXpath);
@ -278,9 +267,6 @@ describe('comment tests', async () => {
let postButton = await findByXpath(replyRow + '//button[@class = "button compose-post"]');
await postButton.click();
// find reply
await driver.sleep(500);
await driver.get(projectUrl);
let postedReply = await findByXpath(`//span[contains(text(), "${projectReply}")]`);
let commentVisible = await postedReply.isDisplayed();
await expect(commentVisible).toBe(true);
@ -299,7 +285,6 @@ describe('comment tests', async () => {
// click post
await clickXpath(commentXpath + '//a[contains(text(), "Post")]');
// reload the page step has been skipped because caching causes failure
// The reply wasn't findable by xpath after several attempts, but it seems
// better to have this much of a test
});
@ -321,9 +306,8 @@ describe('comment tests', async () => {
let postButton = await findByXpath(replyRow + '//button[@class = "button compose-post"]');
await postButton.click();
// reload page and find reply
let replyXpath = `//span[contains(text(), "${studioReply}")]`;
let postedReply = await loadPageUntilVisible(studioUrl, replyXpath, 10);
// find reply
let postedReply = await findByXpath(`//span[contains(text(), "${studioReply}")]`);
let commentVisible = await postedReply.isDisplayed();
await expect(commentVisible).toBe(true);
});

14
test/integration/selenium-helpers.js
View file

@ -202,20 +202,6 @@ class SeleniumHelper {
await driver.wait(until.elementIsVisible(element));
}
async loadPageUntilVisible (url, elementXpath, maxTries) {
for (let i = 0; i < maxTries; i++){
try {
await this.driver.get(url);
let element = await this.driver.wait(until.elementLocated(
By.xpath(elementXpath)), 200, 'could not find element within 200ms');
return await element;
} catch (e) {
// :) eslint-disable-line no-console
}
}
console.error('reached max tries looking for ' + elementXpath); // eslint-disable-line no-console
}
}
module.exports = SeleniumHelper;