scratchfoundation/scratch-webpack-configuration
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-webpack-configuration.git synced 2024-11-22 23:57:55 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat: default to publicPath: '/' and allow overrides
Some checks failed
CI/CD / ci-cd (push) Has been cancelled
Details

Browse source
This commit is contained in:
Georgi Angelov 2024-09-24 12:25:45 +03:00
parent 89d4f7de4c
commit ec47b45ea0
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/index.cjs
View file

@ -31,14 +31,15 @@ const toPath = path => {
class ScratchWebpackConfigBuilder { class ScratchWebpackConfigBuilder {
/** /**
* @param {object} options Options for the webpack configuration. * @param {object} options Options for the webpack configuration.
* @param {string|URL} options.rootPath The absolute path to the project root. * @param {string|URL} [options.rootPath] The absolute path to the project root.
* @param {string|URL} [options.distPath] The absolute path to build output. Defaults to `dist` under `rootPath`. * @param {string|URL} [options.distPath] The absolute path to build output. Defaults to `dist` under `rootPath`.
* @param {string|URL} [options.publicPath] The public location where the output assets will be located. Defaults to `/`.
* @param {boolean} [options.enableReact] Whether to enable React and JSX support. * @param {boolean} [options.enableReact] Whether to enable React and JSX support.
* @param {string} [options.libraryName] The name of the library to build. Shorthand for `output.library.name`. * @param {string} [options.libraryName] The name of the library to build. Shorthand for `output.library.name`.
* @param {string|URL} [options.srcPath] The absolute path to the source files. Defaults to `src` under `rootPath`. * @param {string|URL} [options.srcPath] The absolute path to the source files. Defaults to `src` under `rootPath`.
* @param {boolean} [options.shouldSplitChunks] Whether to enable spliting code to chunks. * @param {boolean} [options.shouldSplitChunks] Whether to enable spliting code to chunks.
*/ */
constructor ({ distPath, enableReact, enableTs, libraryName, rootPath, srcPath, shouldSplitChunks }) { constructor ({ distPath, enableReact, enableTs, libraryName, rootPath, srcPath, publicPath = '/', shouldSplitChunks }) {
const isProduction = process.env.NODE_ENV === 'production'; const isProduction = process.env.NODE_ENV === 'production';
const mode = isProduction ? 'production' : 'development'; const mode = isProduction ? 'production' : 'development';
@ -83,6 +84,8 @@ class ScratchWebpackConfigBuilder {
assetModuleFilename: DEFAULT_ASSET_FILENAME, assetModuleFilename: DEFAULT_ASSET_FILENAME,
chunkFilename: DEFAULT_CHUNK_FILENAME, chunkFilename: DEFAULT_CHUNK_FILENAME,
path: this._distPath, path: this._distPath,
// See https://github.com/scratchfoundation/scratch-editor/pull/25/files/9bc537f9bce35ee327b74bd6715d6c5140f73937#r1763073684
publicPath,
library: { library: {
name: libraryName, name: libraryName,
type: 'umd2' type: 'umd2'