mirror of
https://github.com/scratchfoundation/scratch-vm.git
synced 2024-12-25 07:22:33 -05:00
840ffb5df0
Newer versions of `tap` run more asynchronously, so sometimes using `process.nextTick(process.exit)` to end a test would prevent the test from completing correctly. Removing all instances of `process.nextTick(process.exit)` put tests into three categories: * the test still worked correctly -- no fixup needed. * the test would hang because the VM's `_steppingInterval` was keeping Node alive. These tests call a new `quit()` method which ends the stepping interval. * the `load-extensions` test needed special attention because the "Video Sensing" extension starts its own loop using `setTimeout`. I added a `_stopLoop()` method on the extension and directly call that from the test. I'm not completely happy with this solution but anything more general would likely require a change to the extension spec, so I'm leaving that as a followup task.
42 lines
1.7 KiB
JavaScript
42 lines
1.7 KiB
JavaScript
const path = require('path');
|
|
const test = require('tap').test;
|
|
const makeTestStorage = require('../fixtures/make-test-storage');
|
|
const readFileToBuffer = require('../fixtures/readProjectFile').readFileToBuffer;
|
|
const VirtualMachine = require('../../src/index');
|
|
|
|
const projectUri = path.resolve(__dirname, '../fixtures/monitored_variables.sb3');
|
|
const project = readFileToBuffer(projectUri);
|
|
|
|
const anotherProjectUri = path.resolve(__dirname, '../fixtures/default.sb2');
|
|
const anotherProject = readFileToBuffer(anotherProjectUri);
|
|
|
|
test('importing one project after the other resets monitored variables', t => {
|
|
const vm = new VirtualMachine();
|
|
vm.attachStorage(makeTestStorage());
|
|
|
|
// Start VM, load project, and run
|
|
vm.start();
|
|
vm.clear();
|
|
vm.setCompatibilityMode(false);
|
|
vm.setTurboMode(false);
|
|
vm.loadProject(project).then(() => {
|
|
const refSprite = vm.runtime.targets[1];
|
|
const refVarId = Object.keys(refSprite.variables)[0];
|
|
const refBlock = vm.runtime.monitorBlocks.getBlock(refVarId);
|
|
t.ok(refBlock);
|
|
const jamalSprite = vm.runtime.targets[2];
|
|
const jamalVarId = Object.keys(jamalSprite.variables)[0];
|
|
const jamalBlock = vm.runtime.monitorBlocks.getBlock(jamalVarId);
|
|
t.ok(jamalBlock);
|
|
vm.loadProject(anotherProject).then(() => {
|
|
// Blocks from the previously loaded project should be gone.
|
|
const refVarBlock = vm.runtime.monitorBlocks.getBlock(refVarId);
|
|
t.notOk(refVarBlock);
|
|
const jamalVarBlock = vm.runtime.monitorBlocks.getBlock(jamalVarId);
|
|
t.notOk(jamalVarBlock);
|
|
|
|
vm.quit();
|
|
t.end();
|
|
});
|
|
});
|
|
});
|