mirror of
https://github.com/scratchfoundation/scratch-vm.git
synced 2024-12-23 06:23:37 -05:00
840ffb5df0
Newer versions of `tap` run more asynchronously, so sometimes using `process.nextTick(process.exit)` to end a test would prevent the test from completing correctly. Removing all instances of `process.nextTick(process.exit)` put tests into three categories: * the test still worked correctly -- no fixup needed. * the test would hang because the VM's `_steppingInterval` was keeping Node alive. These tests call a new `quit()` method which ends the stepping interval. * the `load-extensions` test needed special attention because the "Video Sensing" extension starts its own loop using `setTimeout`. I added a `_stopLoop()` method on the extension and directly call that from the test. I'm not completely happy with this solution but anything more general would likely require a change to the extension spec, so I'm leaving that as a followup task.
55 lines
2.3 KiB
JavaScript
55 lines
2.3 KiB
JavaScript
const path = require('path');
|
|
const test = require('tap').test;
|
|
const makeTestStorage = require('../fixtures/make-test-storage');
|
|
const readFileToBuffer = require('../fixtures/readProjectFile').readFileToBuffer;
|
|
const VirtualMachine = require('../../src/index');
|
|
|
|
const uri = path.resolve(__dirname, '../fixtures/unknown-opcode.sb2');
|
|
const project = readFileToBuffer(uri);
|
|
|
|
test('unknown opcode', t => {
|
|
const vm = new VirtualMachine();
|
|
vm.attachStorage(makeTestStorage());
|
|
|
|
vm.start();
|
|
vm.clear();
|
|
vm.setCompatibilityMode(false);
|
|
vm.setTurboMode(false);
|
|
vm.loadProject(project).then(() => {
|
|
vm.greenFlag();
|
|
|
|
// The project has 3 blocks in a single stack:
|
|
// play sound => "undefined" => play sound
|
|
// the "undefined" block has opcode "0" and was found in the wild.
|
|
// It should be parsed in without error and it should bridge together
|
|
// the two play sound blocks, so there should not be a third block.
|
|
const blocks = vm.runtime.targets[0].blocks;
|
|
const topBlockId = blocks.getScripts()[0];
|
|
const secondBlockId = blocks.getNextBlock(topBlockId);
|
|
const thirdBlockId = blocks.getNextBlock(secondBlockId);
|
|
|
|
t.equal(blocks.getBlock(topBlockId).opcode, 'sound_play');
|
|
t.equal(blocks.getBlock(secondBlockId).opcode, 'sound_play');
|
|
t.equal(thirdBlockId, null);
|
|
|
|
const target = vm.runtime.targets[0];
|
|
const topCommentId = blocks.getBlock(topBlockId).comment;
|
|
const secondCommentId = blocks.getBlock(secondBlockId).comment;
|
|
|
|
t.equal(target.comments[topCommentId].text, 'pop1 comment');
|
|
t.equal(target.comments[secondCommentId].text, 'pop2 comment');
|
|
|
|
// The comment previously attached to the undefined block should become
|
|
// a workspace comment, at 0/0, with the same text as it had.
|
|
const undefinedCommentId = Object.keys(target.comments).filter(id =>
|
|
id !== topCommentId && id !== secondCommentId)[0];
|
|
const undefinedComment = target.comments[undefinedCommentId];
|
|
t.equal(undefinedComment.blockId, null);
|
|
t.equal(undefinedComment.text, 'undefined comment');
|
|
t.equal(undefinedComment.x, 0);
|
|
t.equal(undefinedComment.y, 0);
|
|
|
|
vm.quit();
|
|
t.end();
|
|
});
|
|
});
|