mirror of
https://github.com/scratchfoundation/scratch-vm.git
synced 2024-12-23 06:23:37 -05:00
840ffb5df0
Newer versions of `tap` run more asynchronously, so sometimes using `process.nextTick(process.exit)` to end a test would prevent the test from completing correctly. Removing all instances of `process.nextTick(process.exit)` put tests into three categories: * the test still worked correctly -- no fixup needed. * the test would hang because the VM's `_steppingInterval` was keeping Node alive. These tests call a new `quit()` method which ends the stepping interval. * the `load-extensions` test needed special attention because the "Video Sensing" extension starts its own loop using `setTimeout`. I added a `_stopLoop()` method on the extension and directly call that from the test. I'm not completely happy with this solution but anything more general would likely require a change to the extension spec, so I'm leaving that as a followup task.
52 lines
1.8 KiB
JavaScript
52 lines
1.8 KiB
JavaScript
const path = require('path');
|
|
const test = require('tap').test;
|
|
const makeTestStorage = require('../fixtures/make-test-storage');
|
|
const readFileToBuffer = require('../fixtures/readProjectFile').readFileToBuffer;
|
|
const VirtualMachine = require('../../src/index');
|
|
|
|
const projectUri = path.resolve(__dirname, '../fixtures/list-monitor-rename.sb3');
|
|
const project = readFileToBuffer(projectUri);
|
|
|
|
test('importing sb3 project with incorrect list monitor name', t => {
|
|
const vm = new VirtualMachine();
|
|
vm.attachStorage(makeTestStorage());
|
|
|
|
// Evaluate playground data and exit
|
|
vm.on('playgroundData', () => {
|
|
const stage = vm.runtime.targets[0];
|
|
const cat = vm.runtime.targets[1];
|
|
|
|
for (const {target, renamedListName} of [
|
|
{target: stage, renamedListName: 'renamed global'},
|
|
{target: cat, renamedListName: 'renamed local'}
|
|
]) {
|
|
const listId = Object.keys(target.variables).find(k => target.variables[k].name === renamedListName);
|
|
|
|
const monitorRecord = vm.runtime._monitorState.get(listId);
|
|
const monitorBlock = vm.runtime.monitorBlocks.getBlock(listId);
|
|
t.equal(monitorRecord.opcode, 'data_listcontents');
|
|
|
|
// The list name should be properly renamed
|
|
t.equal(monitorRecord.params.LIST, renamedListName);
|
|
t.equal(monitorBlock.fields.LIST.value, renamedListName);
|
|
}
|
|
|
|
vm.quit();
|
|
t.end();
|
|
});
|
|
|
|
// Start VM, load project, and run
|
|
t.doesNotThrow(() => {
|
|
vm.start();
|
|
vm.clear();
|
|
vm.setCompatibilityMode(false);
|
|
vm.setTurboMode(false);
|
|
vm.loadProject(project).then(() => {
|
|
vm.greenFlag();
|
|
setTimeout(() => {
|
|
vm.getPlaygroundData();
|
|
vm.stopAll();
|
|
}, 100);
|
|
});
|
|
});
|
|
});
|