Merge pull request from paulkaplan/fix-clone-drag

Only select the original target after a drag.
This commit is contained in:
Paul Kaplan 2018-04-11 10:04:25 -04:00 committed by GitHub
commit f23b5a9625
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 1 deletions

View file

@ -921,7 +921,8 @@ class VirtualMachine extends EventEmitter {
if (target) {
this._dragTarget = null;
target.stopDrag();
this.setEditingTarget(target.id);
this.setEditingTarget(target.sprite && target.sprite.clones[0] ?
target.sprite.clones[0].id : target.id);
}
}

View file

@ -379,3 +379,30 @@ test('drag IO redirect', t => {
t.equal(sprite2Info[1], 'sprite2 info 2');
t.end();
});
test('select original after dragging clone', t => {
const vm = new VirtualMachine();
let newEditingTargetId = null;
vm.setEditingTarget = id => {
newEditingTargetId = id;
};
vm.runtime.targets = [
{
id: 'sprite1_clone',
sprite: {clones: [{id: 'sprite1_original'}]},
stopDrag: () => {}
}, {
id: 'sprite2',
stopDrag: () => {}
}
];
// Stop drag on a bare target selects that target
vm.stopDrag('sprite2');
t.equal(newEditingTargetId, 'sprite2');
// Stop drag on target with parent sprite selects the 0th clone of that sprite
vm.stopDrag('sprite1_clone');
t.equal(newEditingTargetId, 'sprite1_original');
t.end();
});