scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 06:52:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Address feedback

Browse source
This commit is contained in:
Valerie R Young 2018-11-14 14:24:09 -05:00
parent b64d18b627
commit ebd3b46cc2
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/serialization/sb2.js
View file

@ -843,7 +843,6 @@ const parseBlock = function (sb2block, addBroadcastMsg, getVariableId, extension
for (let i = 0; i < blockMetadata.argMap.length; i++) { for (let i = 0; i < blockMetadata.argMap.length; i++) {
const expectedArg = blockMetadata.argMap[i]; const expectedArg = blockMetadata.argMap[i];
const providedArg = sb2block[i + 1]; // (i = 0 is opcode) const providedArg = sb2block[i + 1]; // (i = 0 is opcode)
// Whether the input is obscuring a shadow. // Whether the input is obscuring a shadow.
let shadowObscured = false; let shadowObscured = false;
// Positional argument is an input. // Positional argument is an input.
@ -873,9 +872,6 @@ const parseBlock = function (sb2block, addBroadcastMsg, getVariableId, extension
} }
parseState.expectedArg = parentExpectedArg; parseState.expectedArg = parentExpectedArg;
// Obscures any shadow.
shadowObscured = true;
// Check if innerBlocks is not an empty list. // Check if innerBlocks is not an empty list.
// An empty list indicates that all the inner blocks from the sb2 have // An empty list indicates that all the inner blocks from the sb2 have
// unknown opcodes and have been skipped. // unknown opcodes and have been skipped.
@ -896,6 +892,9 @@ const parseBlock = function (sb2block, addBroadcastMsg, getVariableId, extension
activeBlock.children.concat(innerBlocks) activeBlock.children.concat(innerBlocks)
); );
} }
// Obscures any shadow.
shadowObscured = true;
} }
// Generate a shadow block to occupy the input. // Generate a shadow block to occupy the input.
if (!expectedArg.inputOp) { if (!expectedArg.inputOp) {