Microbit display commands yield for a tick ()

* Microbit display commands yield for a tick

* JSDOC fixes
This commit is contained in:
Eric Rosenbaum 2018-07-12 15:19:28 -04:00 committed by GitHub
parent 0c21f739ec
commit ea1bb602f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -507,7 +507,7 @@ class Scratch3MicroBitBlocks {
/** /**
* Display a predefined symbol on the 5x5 LED matrix. * Display a predefined symbol on the 5x5 LED matrix.
* @param {object} args - the block's arguments. * @param {object} args - the block's arguments.
* @return {Promise} - a Promise that resolves when writing to device. * @return {Promise} - a Promise that resolves after a tick.
*/ */
displaySymbol (args) { displaySymbol (args) {
const symbol = cast.toString(args.MATRIX); const symbol = cast.toString(args.MATRIX);
@ -522,29 +522,33 @@ class Scratch3MicroBitBlocks {
this._device.ledMatrixState[2] = (hex >> 10) & 0x1F; this._device.ledMatrixState[2] = (hex >> 10) & 0x1F;
this._device.ledMatrixState[3] = (hex >> 15) & 0x1F; this._device.ledMatrixState[3] = (hex >> 15) & 0x1F;
this._device.ledMatrixState[4] = (hex >> 20) & 0x1F; this._device.ledMatrixState[4] = (hex >> 20) & 0x1F;
return this._device.displayMatrix(this._device.ledMatrixState); this._device.displayMatrix(this._device.ledMatrixState);
return Promise.resolve();
} }
/** /**
* Display text on the 5x5 LED matrix. * Display text on the 5x5 LED matrix.
* @param {object} args - the block's arguments. * @param {object} args - the block's arguments.
* @return {Promise} - a Promise that resolves when writing to device. * @return {Promise} - a Promise that resolves after a tick.
* Note the limit is 19 characters * Note the limit is 19 characters
*/ */
displayText (args) { displayText (args) {
const text = String(args.TEXT).substring(0, 19); const text = String(args.TEXT).substring(0, 19);
return this._device.displayText(text); this._device.displayText(text);
return Promise.resolve();
} }
/** /**
* Turn all 5x5 matrix LEDs off. * Turn all 5x5 matrix LEDs off.
* @return {Promise} - a Promise that resolves after a tick.
*/ */
displayClear () { displayClear () {
for (let i = 0; i < 5; i++) { for (let i = 0; i < 5; i++) {
this._device.ledMatrixState[i] = 0; this._device.ledMatrixState[i] = 0;
} }
this._device.displayMatrix(this._device.ledMatrixState); this._device.displayMatrix(this._device.ledMatrixState);
return; return Promise.resolve();
} }
/** /**