From 30a1ba52e31c4c1ace7dcf6a0220d33402b9c68b Mon Sep 17 00:00:00 2001 From: Christopher Willis-Ford Date: Mon, 19 Nov 2018 11:57:43 -0800 Subject: [PATCH 1/2] Use absolute path for worker shim in dispatch test Node 11 causes TinyWorker to resolve its start script path differently, compared to Node 8. Using an absolute path works for both. --- test/unit/dispatch.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/unit/dispatch.js b/test/unit/dispatch.js index fdcbdb3ea..92ed58f0d 100644 --- a/test/unit/dispatch.js +++ b/test/unit/dispatch.js @@ -49,7 +49,8 @@ test('local', t => { test('remote', t => { const fixturesDir = path.resolve(__dirname, '../fixtures'); - const worker = new Worker('./test/fixtures/dispatch-test-worker-shim.js', null, {cwd: fixturesDir}); + const shimPath = path.resolve(fixturesDir, 'dispatch-test-worker-shim.js'); + const worker = new Worker(shimPath, null, {cwd: fixturesDir}); dispatch.addWorker(worker); const waitForWorker = new Promise(resolve => { From 812455db7c90b218db8146e0eaf72b1969208260 Mon Sep 17 00:00:00 2001 From: Christopher Willis-Ford Date: Mon, 19 Nov 2018 12:09:38 -0800 Subject: [PATCH 2/2] Explicitly specify Node versions for Travis --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index cfb067c24..d0767d4ab 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,7 @@ language: node_js node_js: - 8 -- node +- 10 env: global: - NODE_ENV=production