From df9230a0ff98317ea3303dd437d906b1ec907b8d Mon Sep 17 00:00:00 2001 From: Paul Kaplan Date: Tue, 23 May 2017 09:55:42 -0400 Subject: [PATCH] Make helper private --- src/engine/blocks.js | 39 +++++++++++++++++++-------------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/src/engine/blocks.js b/src/engine/blocks.js index c05951711..8a3436f52 100644 --- a/src/engine/blocks.js +++ b/src/engine/blocks.js @@ -267,25 +267,6 @@ class Blocks { } } - /** - * Serialize block fields and input fields for reporting new monitors - * @param {!object} block Block to be paramified. - * @return {!object} object of param key/values. - */ - getBlockParams (block) { - const params = {}; - for (const key in block.fields) { - params[key] = block.fields[key].value; - } - for (const inputKey in block.inputs) { - const inputBlock = this._blocks[block.inputs[inputKey].block]; - for (const key in inputBlock.fields) { - params[key] = inputBlock.fields[key].value; - } - } - return params; - } - /** * Block management: change block field values * @param {!object} args Blockly change event to be processed @@ -316,7 +297,7 @@ class Blocks { // @todo(vm#564) this will collide if multiple sprites use same block id: block.id, opcode: block.opcode, - params: this.getBlockParams(block), + params: this._getBlockParams(block), // @todo(vm#565) for numerical values with decimals, some countries use comma value: '' }); @@ -525,6 +506,24 @@ class Blocks { } // --------------------------------------------------------------------- + /** + * Helper to serialize block fields and input fields for reporting new monitors + * @param {!object} block Block to be paramified. + * @return {!object} object of param key/values. + */ + _getBlockParams (block) { + const params = {}; + for (const key in block.fields) { + params[key] = block.fields[key].value; + } + for (const inputKey in block.inputs) { + const inputBlock = this._blocks[block.inputs[inputKey].block]; + for (const key in inputBlock.fields) { + params[key] = inputBlock.fields[key].value; + } + } + return params; + } /** * Helper to add a stack to `this._scripts`.