scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-23 22:42:27 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Convert motor duration: seconds -> milliseconds

Browse source 
The block takes seconds, whereas the device takes milliseconds. Turning
on a motor for 1 millisecond isn't very dramatic.
This commit is contained in:
Christopher Willis-Ford 2017-05-11 22:39:24 -07:00
parent 06fe701624
commit cbfbc5d600
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/blocks/scratch3_wedo2.js
View file

@ -456,13 +456,14 @@ class Scratch3WeDo2Blocks {
* @return {Promise} - a promise which will resolve at the end of the duration. * @return {Promise} - a promise which will resolve at the end of the duration.
*/ */
motorOnFor (args) { motorOnFor (args) {
const durationMS = args.DURATION * 1000;
return new Promise(resolve => { return new Promise(resolve => {
this._forEachMotor(args.MOTOR_ID, motorIndex => { this._forEachMotor(args.MOTOR_ID, motorIndex => {
this._device.motor(motorIndex).setMotorOnFor(args.DURATION); this._device.motor(motorIndex).setMotorOnFor(durationMS);
}); });
// Ensure this block runs for a fixed amount of time even when no device is connected. // Ensure this block runs for a fixed amount of time even when no device is connected.
setTimeout(resolve, args.DURATION); setTimeout(resolve, durationMS);
}); });
} }