scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 15:02:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add new event for all visual target changes, not just moving.

Browse source
This commit is contained in:
Paul Kaplan 2018-04-20 10:43:45 -04:00
parent d42135a40a
commit c36ff056a2
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/sprites/rendered-target.js
View file

@ -193,6 +193,14 @@ class RenderedTarget extends Target {
return 'TARGET_MOVED'; return 'TARGET_MOVED';
} }
/**
* Event which fires when a target changes visually, for updating say bubbles.
* @type {string}
*/
static get EVENT_TARGET_VISUAL_CHANGE () {
return 'EVENT_TARGET_VISUAL_CHANGE';
}
/** /**
* Rotation style for "all around"/spinning. * Rotation style for "all around"/spinning.
* @type {string} * @type {string}
@ -249,6 +257,7 @@ class RenderedTarget extends Target {
position: position position: position
}); });
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} else { } else {
@ -299,6 +308,7 @@ class RenderedTarget extends Target {
scale: renderedDirectionScale.scale scale: renderedDirectionScale.scale
}); });
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -346,6 +356,7 @@ class RenderedTarget extends Target {
visible: this.visible visible: this.visible
}); });
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -378,6 +389,7 @@ class RenderedTarget extends Target {
scale: renderedDirectionScale.scale scale: renderedDirectionScale.scale
}); });
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -397,6 +409,7 @@ class RenderedTarget extends Target {
props[effectName] = this.effects[effectName]; props[effectName] = this.effects[effectName];
this.renderer.updateDrawableProperties(this.drawableID, props); this.renderer.updateDrawableProperties(this.drawableID, props);
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -413,6 +426,7 @@ class RenderedTarget extends Target {
if (this.renderer) { if (this.renderer) {
this.renderer.updateDrawableProperties(this.drawableID, this.effects); this.renderer.updateDrawableProperties(this.drawableID, this.effects);
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -446,6 +460,7 @@ class RenderedTarget extends Target {
} }
this.renderer.updateDrawableProperties(this.drawableID, drawableProperties); this.renderer.updateDrawableProperties(this.drawableID, drawableProperties);
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -573,6 +588,7 @@ class RenderedTarget extends Target {
scale: renderedDirectionScale.scale scale: renderedDirectionScale.scale
}); });
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -645,6 +661,7 @@ class RenderedTarget extends Target {
} }
this.renderer.updateDrawableProperties(this.drawableID, props); this.renderer.updateDrawableProperties(this.drawableID, props);
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }
@ -1034,6 +1051,7 @@ class RenderedTarget extends Target {
if (this.renderer && this.drawableID !== null) { if (this.renderer && this.drawableID !== null) {
this.renderer.destroyDrawable(this.drawableID); this.renderer.destroyDrawable(this.drawableID);
if (this.visible) { if (this.visible) {
this.emit(RenderedTarget.EVENT_TARGET_VISUAL_CHANGE, this);
this.runtime.requestRedraw(); this.runtime.requestRedraw();
} }
} }