scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 23:12:24 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix issue where deleting a sprite with a monitored local variable creates that local variable on all other sprites after switching sprites twice or more.

Browse source
This commit is contained in:
Karishma Chadha 2018-08-15 14:31:40 -04:00
parent c21d5eba1c
commit b95350da6e
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/virtual-machine.js
View file

@ -852,7 +852,14 @@ class VirtualMachine extends EventEmitter {
} }
const spritePromise = this.exportSprite(targetId, 'uint8array'); const spritePromise = this.exportSprite(targetId, 'uint8array');
const restoreSprite = () => spritePromise.then(spriteBuffer => this.addSprite(spriteBuffer)); const restoreSprite = () => spritePromise.then(spriteBuffer => this.addSprite(spriteBuffer));
// Remove monitors from the runtime state and remove the
// target-specific monitored blocks (e.g. local variables)
this.runtime.requestRemoveMonitorByTargetId(targetId); this.runtime.requestRemoveMonitorByTargetId(targetId);
const targetSpecificMonitorBlockIds = Object.keys(this.runtime.monitorBlocks._blocks)
.filter(key => this.runtime.monitorBlocks._blocks[key].targetId === targetId);
for (const blockId of targetSpecificMonitorBlockIds) {
this.runtime.monitorBlocks.deleteBlock(blockId);
}
const currentEditingTarget = this.editingTarget; const currentEditingTarget = this.editingTarget;
for (let i = 0; i < sprite.clones.length; i++) { for (let i = 0; i < sprite.clones.length; i++) {
const clone = sprite.clones[i]; const clone = sprite.clones[i];