scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-06-12 13:31:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions1

Address feedback from review

Browse source
This commit is contained in:
Andrew Sliwinski 2017-11-27 15:00:53 -05:00
parent a73ef6819f
commit b78bdb4c93
2 changed files with 13 additions and 8 deletions

2
src/io/deviceManager.js
View file

@ -319,7 +319,7 @@ class DeviceManager {
json: {}
}, (err, res, body) => {
if (err) return reject(err);
if (res.statusCode !== 200) reject(body);
if (res.statusCode !== 200) return reject(body);
resolve(body);
});
});

19
test/unit/io_deviceManager.js
View file

@ -24,11 +24,16 @@ test('list', t => {
const deviceManager = new DeviceManager();
deviceManager
.list('test', 'test', null)
.catch(err => {
t.true((typeof err === 'undefined') || (typeof err === 'object'));
})
.then(body => {
t.true((typeof body === 'undefined') || (typeof body === 'object'));
t.end();
});
.then(
body => {
// SDM is running
t.type(body, 'object');
t.end();
},
err => {
// If SDM is not running error is expected, continue
t.true(typeof err === 'object' || typeof err === 'undefined');
t.end();
}
);
});