scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-01-11 10:39:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Only update costume rotationCenter if it exists

Browse source 
This prevents sending `NaN`s to the renderer as the rotation center, which prevents the initial render of the costume/backdrop.

Towards LLK/scratch-gui#18
This commit is contained in:
Ray Schamp 2017-01-13 12:55:21 -05:00
parent 4ba76bbdbd
commit a56346d0a9
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/sprites/rendered-target.js
View file

@ -329,18 +329,21 @@ RenderedTarget.prototype.setCostume = function (index) {
);
if (this.renderer) {
var costume = this.sprite.costumes[this.currentCostume];
var rotationCenter = costume.bitmapResolution ? [
costume.rotationCenterX / costume.bitmapResolution,
costume.rotationCenterY / costume.bitmapResolution
] : [
costume.rotationCenterX,
costume.rotationCenterY
];
this.renderer.updateDrawableProperties(this.drawableID, {
var drawableProperties = {
skin: costume.skin,
costumeResolution: costume.bitmapResolution,
rotationCenter: rotationCenter
});
costumeResolution: costume.bitmapResolution
};
if (
typeof costume.rotationCenterX !== 'undefined' &&
typeof costume.rotationCenterY !== 'undefined'
) {
var scale = costume.bitmapResolution || 1;
drawableProperties.rotationCenter = [
costume.rotationCenterX / scale,
costume.rotationCenterY / scale
];
}
this.renderer.updateDrawableProperties(this.drawableID, drawableProperties);
if (this.visible) {
this.runtime.requestRedraw();
}