scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-07-28 06:59:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions1

Deal with comments attached to undefined blocks

Browse source 
Also fix an issue where you couldn't save/load projects that had multiple comments linked to a single block.
This commit is contained in:
Paul Kaplan 2018-06-26 16:41:10 -04:00
parent e7e300caeb
commit 9f517bd483
3 changed files with 47 additions and 18 deletions
test/integration
unknown-opcode.js

18
test/integration/unknown-opcode.js
View file

@ -31,6 +31,24 @@ test('unknown opcode', t => {
t.equal(blocks.getBlock(topBlockId).opcode, 'sound_play');
t.equal(blocks.getBlock(secondBlockId).opcode, 'sound_play');
t.equal(thirdBlockId, null);
const target = vm.runtime.targets[0];
const topCommentId = blocks.getBlock(topBlockId).comment;
const secondCommentId = blocks.getBlock(secondBlockId).comment;
t.equal(target.comments[topCommentId].text, 'pop1 comment');
t.equal(target.comments[secondCommentId].text, 'pop2 comment');
// The comment previously attached to the undefined block should become
// a workspace comment, at 0/0, with the same text as it had.
const undefinedCommentId = Object.keys(target.comments).filter(id =>
id !== topCommentId && id !== secondCommentId)[0];
const undefinedComment = target.comments[undefinedCommentId];
t.equal(undefinedComment.blockId, null);
t.equal(undefinedComment.text, 'undefined comment');
t.equal(undefinedComment.x, 0);
t.equal(undefinedComment.y, 0);
t.end();
process.nextTick(process.exit);
});