scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-01-25 00:49:53 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use new Scratch-specific callback keys for extension buttons

Browse source
This commit is contained in:
Christopher Willis-Ford 2019-04-02 22:44:23 -07:00
parent d59c6a0b73
commit 9eef05a7c5
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/engine/runtime.js
View file

@ -1166,7 +1166,7 @@ class Runtime extends EventEmitter {
*/ */
_convertButtonForScratchBlocks (buttonInfo) { _convertButtonForScratchBlocks (buttonInfo) {
// for now we only support these pre-defined callbacks handled in scratch-blocks // for now we only support these pre-defined callbacks handled in scratch-blocks
const supportedCallbackKeys = ['CREATE_LIST', 'CREATE_PROCEDURE', 'CREATE_VARIABLE']; const supportedCallbackKeys = ['MAKE_A_LIST', 'MAKE_A_PROCEDURE', 'MAKE_A_VARIABLE'];
if (supportedCallbackKeys.indexOf(buttonInfo.func) < 0) { if (supportedCallbackKeys.indexOf(buttonInfo.func) < 0) {
log.error(`Custom button callbacks not supported yet: ${buttonInfo.func}`); log.error(`Custom button callbacks not supported yet: ${buttonInfo.func}`);
} }

4
test/unit/extension_conversion.js
View file

@ -13,7 +13,7 @@ const testExtensionInfo = {
name: 'fake test extension', name: 'fake test extension',
blocks: [ blocks: [
{ {
func: 'CREATE_VARIABLE', func: 'MAKE_A_VARIABLE',
blockType: BlockType.BUTTON, blockType: BlockType.BUTTON,
text: 'this is a button' text: 'this is a button'
}, },
@ -65,7 +65,7 @@ const testExtensionInfo = {
const testButton = function (t, button) { const testButton = function (t, button) {
t.same(button.json, null); // should be null or undefined t.same(button.json, null); // should be null or undefined
t.equal(button.xml, '<button text="this is a button" callbackKey="CREATE_VARIABLE"></button>'); t.equal(button.xml, '<button text="this is a button" callbackKey="MAKE_A_VARIABLE"></button>');
}; };
const testReporter = function (t, reporter) { const testReporter = function (t, reporter) {