scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 15:02:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #4092 from scratchfoundation/disable-metadata

Browse source 
fix: disable metadata for now
This commit is contained in:
Christopher Willis-Ford 2023-10-03 07:14:57 -07:00 committed by GitHub
commit 8ba0e2f1b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/engine/runtime.js
View file

@ -1,6 +1,6 @@
const EventEmitter = require('events'); const EventEmitter = require('events');
const {OrderedMap} = require('immutable'); const {OrderedMap} = require('immutable');
const uuid = require('uuid'); // const uuid = require('uuid');
const ArgumentType = require('../extension-support/argument-type'); const ArgumentType = require('../extension-support/argument-type');
const Blocks = require('./blocks'); const Blocks = require('./blocks');
@ -2032,8 +2032,9 @@ class Runtime extends EventEmitter {
return; return;
} }
const newRunId = uuid.v1(); // TODO: re-enable metadata
this.storage.scratchFetch.setMetadata(this.storage.scratchFetch.RequestMetadata.RunId, newRunId); // const newRunId = uuid.v1();
// this.storage.scratchFetch.setMetadata(this.storage.scratchFetch.RequestMetadata.RunId, newRunId);
} }
/** /**

5
test/integration/runId.js
View file

@ -1,6 +1,6 @@
const Worker = require('tiny-worker'); const Worker = require('tiny-worker');
const path = require('path'); const path = require('path');
const test = require('tap').test; const test = require('tap');
const VirtualMachine = require('../../src/index'); const VirtualMachine = require('../../src/index');
const dispatch = require('../../src/dispatch/central-dispatch'); const dispatch = require('../../src/dispatch/central-dispatch');
@ -15,7 +15,8 @@ const project = readFileToBuffer(uri);
// By default Central Dispatch works with the Worker class built into the browser. Tell it to use TinyWorker instead. // By default Central Dispatch works with the Worker class built into the browser. Tell it to use TinyWorker instead.
dispatch.workerClass = Worker; dispatch.workerClass = Worker;
test('runId', async t => { // TODO: re-enable metadata
test.skip('runId', async t => {
const guidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/; const guidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/;
const isGuid = data => guidRegex.test(data); const isGuid = data => guidRegex.test(data);